Remove flyteidl.core.ContainerError tests
#2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]> Remove `flyteidl.core.ContainerError` tests Signed-off-by: Austin Liu <[email protected]>
austin362667
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
pingsutw
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#2811
Why are the changes needed?
As it's not currently supported by PyO3. So it's tricky to support pickling with
flyteidl_rustexposed class.For more details on supporting pickle serialization in PyO3, please check Pickle Support PyO3/pyo3#100 (One of the oldest lasting issues..).
I decided to temporarily mark them as
flyteidl_rustand skip these tests at first. Then @pingsutw told me is reasonable to just remove these tests because they are not used anymore like picklingflyteidl.core.ContainerError.What changes were proposed in this pull request?
vcpkgOpenSSLexecutable in CI.flyteidl.core.ContainerErrorunit tests that needpickleprotocol.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link