-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the unit tests that use Rust FlyteIDL #2811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]> Skip pickle error Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
changed the title
Fix uint tests which use rust flyetidl
Fix the uint tests that use Rust FlyteIDL.
Oct 13, 2024
austin362667
changed the title
Fix the uint tests that use Rust FlyteIDL.
Fix the uint tests that use Rust FlyteIDL
Oct 13, 2024
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
from
October 14, 2024 08:48
5e49fdd
to
2f58296
Compare
Signed-off-by: Austin Liu <[email protected]> Set OPENSSL_DIR based on dynamic build path Signed-off-by: Austin Liu <[email protected]> Set OPENSSL_DIR based on dynamic build path Signed-off-by: Austin Liu <[email protected]> Set OPENSSL_DIR based on dynamic build path Signed-off-by: Austin Liu <[email protected]> Set OPENSSL_DIR based on dynamic build path Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
from
October 14, 2024 09:06
199948c
to
50f6d8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## flyrs-v2 #2811 +/- ##
===========================================
Coverage ? 37.61%
===========================================
Files ? 183
Lines ? 19042
Branches ? 2470
===========================================
Hits ? 7163
Misses ? 11692
Partials ? 187 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Austin Liu <[email protected]> Fix maturin build Signed-off-by: Austin Liu <[email protected]> Fix maturin build Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
from
October 14, 2024 11:33
4febd8b
to
46a4e4f
Compare
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
3 times, most recently
from
October 14, 2024 15:06
38ee3ad
to
169a41a
Compare
Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]> Clean up Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> Add vcpkg Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> Add vcpkg Signed-off-by: Austin Liu <[email protected]> Add vcpkg Signed-off-by: Austin Liu <[email protected]> Add vcpkg Signed-off-by: Austin Liu <[email protected]> Add vcpkg Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> Fix windows link path Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
from
October 15, 2024 02:58
a20bb13
to
91b8ffe
Compare
Signed-off-by: Austin Liu <[email protected]> Fix windows install path Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
flyrs-v2
branch
from
October 15, 2024 04:41
fe3e810
to
a690957
Compare
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
October 16, 2024 12:11
pingsutw
approved these changes
Oct 18, 2024
Future-Outlier
changed the title
Fix the uint tests that use Rust FlyteIDL
Fix the unit tests that use Rust FlyteIDL
Oct 18, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Follow-ups in #2561
Why are the changes needed?
The unit tests of
flyrs-v2
dev branch should also be updated to the correspondingflyteidl_rust
in flyteorg/flyte#5525What changes were proposed in this pull request?
Beyond fixing all unit tests to use new
flyteidl_rust
, there are some pending todos:PyO3 not support pickling in Python:
As it's not currently supported by PyO3. So Flyte keeps failing on pickling exposed
flyteidl_rust
objects.flyteidl_rust
and skip in pytest.OpenSSL linking not found:
openssl[vendored]
crate can't link to OpenSSL. I've tried both static and dynamic linking..dll
file inside the Python module folder.openssl
withrustls
. Please refer to this discussion.How was this patch tested?
Rather than directly installing
flyteidl_rust
from https://test.pypi.org/project/flyteidl-rust/. We buildflyteidl_rust
from flyteorg/flyte#5525 source code to simulate future development process, users modify new protos then build the newflyteidl_rust
python package locally.Setup process
Screenshots
As you can see, only windows CI failed due to
OpenSSL
compilation and static linking error:Check all the applicable boxes
Related PRs
Docs link