Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bc82a6
[Flyte Deck] Extras has been added
101rakibulhasan Oct 4, 2024
df4abbd
Added "All" which will install all the libraries
101rakibulhasan Oct 4, 2024
c0f75b4
Fixed linting issue using both pylint & flake8 on modified lines
101rakibulhasan Oct 4, 2024
00edc62
fix lint
Future-Outlier Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions plugins/flytekit-deck-standard/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@

plugin_requires = ["flytekit"]

extras = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an all that installs all dependencies? pandas is a good example of a library that does this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am working on it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed the update...
Here is the output using All
-> pip install "dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl[all]"
Defaulting to user installation because normal site-packages is not writeable
Processing ./dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl
Requirement already satisfied: flytekit in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (1.13.7)
Requirement already satisfied: markdown in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (3.7)
Requirement already satisfied: pygments in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (2.18.0)
Requirement already satisfied: plotly in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (5.24.1)
Requirement already satisfied: pillow in /usr/lib/python3/dist-packages (from flytekitplugins-deck-standard==0.0.0+develop) (9.0.1)
Requirement already satisfied: ydata-profiling in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (4.10.0)
Requirement already satisfied: pandas in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (2.2.3)

No error was made and the extras were found

'pandas': ['pandas'],
'pillow': ['pillow'],
'ydata-profiling': ['ydata-profiling'],
'markdown': ['markdown'],
'plotly': ['plotly'],
'pygments': ['pygments'],
}

__version__ = "0.0.0+develop"

setup(
Expand All @@ -20,6 +29,7 @@
namespace_packages=["flytekitplugins"],
packages=[f"flytekitplugins.{PLUGIN_NAME}"],
install_requires=plugin_requires,
extras_require=extras,
license="apache2",
python_requires=">=3.8",
classifiers=[
Expand Down
Loading