Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

101rakibulhasan · 2024-10-04T13:12:03Z

Tracking issue

Why are the changes needed?

flytekit-deck-standard's dependency is only flytekit now, however, there are some renders that require requirements and we want the user experience to be more smoothly.
For example, if you import ImageRenderer, you have to also install pillow in your Python environment.
But usually users will raise an error than know that they should install pillow.
We want the user to install flytekitplugins-deck like pip install "flytekit-deck-standard[pandas, ydata-profiling]".

What changes were proposed in this pull request?

I only changed the setup.py on flytekit/plugins/flytekit-deck-standard. This change enables user to have a smooth user experience for package installation. Like they can now write pip install "flytekit-deck-standard[pandas, ydata-profiling] instead of installing extras separately.

How was this patch tested?

I first made sure I don't have the extras packages installed. Then I first build this package via wheel then locally installed it on python via pip like-
" pip install "dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl[pandas,ydata-profiling,markdown,plotly,pygments]" "

Output:
Processing ./dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl
Requirement already satisfied: flytekit in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (1.13.7)
Requirement already satisfied: pygments in /usr/lib/python3/dist-packages (from flytekitplugins-deck-standard==0.0.0+develop) (2.11.2)
Collecting plotly
Downloading plotly-5.24.1-py3-none-any.whl (19.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 19.1/19.1 MB 26.0 kB/s eta 0:00:00
Collecting markdown
Downloading Markdown-3.7-py3-none-any.whl (106 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 106.3/106.3 KB 24.0 kB/s eta 0:00:00
Collecting pandas
Downloading pandas-2.2.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (13.1 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 13.1/13.1 MB 26.6 kB/s eta 0:00:00
Collecting ydata-profiling
Downloading ydata_profiling-4.10.0-py2.py3-none-any.whl (356 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 356.2/356.2 KB 20.7 kB/s eta 0:00:00
Requirement already satisfied: pillow in /usr/lib/python3/dist-packages (from flytekitplugins-deck-standard==0.0.0+develop) (9.0.1)
Requirement already satisfied: statsd>=3.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.0.1)
Requirement already satisfied: keyring>=18.0.1 in /usr/lib/python3/dist-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (23.5.0)
Requirement already satisfied: googleapis-common-protos>=1.57 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.65.0)
Requirement already satisfied: typing-extensions in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.12.2)
Requirement already satisfied: urllib3>=1.22 in /usr/lib/python3/dist-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.26.5)
Requirement already satisfied: adlfs>=2023.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2024.7.0)
Requirement already satisfied: gcsfs>=2023.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2024.9.0.post1)
Requirement already satisfied: mashumaro>=3.11 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.13.1)
Requirement already satisfied: marshmallow-enum in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.5.1)
Requirement already satisfied: s3fs!=2024.3.1,>=2023.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2024.9.0)
Requirement already satisfied: click>=6.6 in /usr/lib/python3/dist-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (8.0.3)
Requirement already satisfied: python-json-logger>=2.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.0.7)
Requirement already satisfied: jsonpickle in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.3.0)
Requirement already satisfied: rich in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (13.9.1)
Requirement already satisfied: croniter>=0.3.20 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.0.3)
Requirement already satisfied: pytimeparse>=1.1.8 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.1.8)
Requirement already satisfied: requests>=2.18.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.32.3)
Requirement already satisfied: docstring-parser>=0.9.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.16)
Requirement already satisfied: dataclasses-json<0.5.12,>=0.5.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.5.9)
Requirement already satisfied: rich-click in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.8.3)
Requirement already satisfied: cloudpickle>=2.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.0.0)
Requirement already satisfied: pyyaml!=5.4.0,!=5.4.1,!=6.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (6.0.2)
Requirement already satisfied: importlib-metadata in /usr/lib/python3/dist-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.6.4)
Requirement already satisfied: docker>=4.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (7.1.0)
Requirement already satisfied: grpcio-status in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.66.2)
Requirement already satisfied: diskcache>=5.2.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (5.6.3)
Requirement already satisfied: flyteidl>=1.13.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.13.4)
Requirement already satisfied: protobuf!=4.25.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (5.28.2)
Requirement already satisfied: joblib in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.4.2)
Requirement already satisfied: markdown-it-py in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.0.0)
Requirement already satisfied: jsonlines in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.0.0)
Requirement already satisfied: grpcio in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.66.2)
Requirement already satisfied: marshmallow-jsonschema>=0.12.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.13.0)
Requirement already satisfied: fsspec>=2023.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2024.9.0)
Requirement already satisfied: python-dateutil>=2.8.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pandas->flytekitplugins-deck-standard==0.0.0+develop) (2.9.0.post0)
Requirement already satisfied: tzdata>=2022.7 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pandas->flytekitplugins-deck-standard==0.0.0+develop) (2024.2)
Requirement already satisfied: pytz>=2020.1 in /usr/lib/python3/dist-packages (from pandas->flytekitplugins-deck-standard==0.0.0+develop) (2022.1)
Requirement already satisfied: numpy>=1.22.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pandas->flytekitplugins-deck-standard==0.0.0+develop) (2.0.2)
Requirement already satisfied: packaging in /home/rakibulhasan/.local/lib/python3.10/site-packages (from plotly->flytekitplugins-deck-standard==0.0.0+develop) (24.1)
Requirement already satisfied: tenacity>=6.2.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from plotly->flytekitplugins-deck-standard==0.0.0+develop) (9.0.0)
Requirement already satisfied: scipy<1.14,>=1.4.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.13.1)
Requirement already satisfied: phik<0.13,>=0.11.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.12.4)
Requirement already satisfied: numba<1,>=0.56.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.60.0)
Requirement already satisfied: pydantic>=2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (2.9.2)
Requirement already satisfied: typeguard<5,>=3 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (4.3.0)
Requirement already satisfied: dacite>=1.8 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.8.1)
Requirement already satisfied: htmlmin==0.1.12 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.1.12)
Requirement already satisfied: multimethod<2,>=1.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.12)
Requirement already satisfied: tqdm<5,>=4.48.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (4.66.5)
Requirement already satisfied: matplotlib<3.10,>=3.5 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (3.9.2)
Requirement already satisfied: imagehash==4.3.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (4.3.1)
Requirement already satisfied: visions[type_image_path]<0.7.7,>=0.7.5 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.7.6)
Requirement already satisfied: wordcloud>=1.9.3 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.9.3)
Requirement already satisfied: statsmodels<1,>=0.13.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.14.4)
Requirement already satisfied: jinja2<3.2,>=2.11.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (3.1.4)
Requirement already satisfied: seaborn<0.14,>=0.10.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.13.2)
Requirement already satisfied: PyWavelets in /home/rakibulhasan/.local/lib/python3.10/site-packages (from imagehash==4.3.1->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.7.0)
Requirement already satisfied: azure-core<2.0.0,>=1.23.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.31.0)
Requirement already satisfied: azure-datalake-store<0.1,>=0.0.46 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.0.53)
Requirement already satisfied: azure-identity in /home/rakibulhasan/.local/lib/python3.10/site-packages (from adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.18.0)
Requirement already satisfied: azure-storage-blob>=12.12.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (12.23.1)
Requirement already satisfied: aiohttp>=3.7.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.10.8)
Requirement already satisfied: marshmallow<4.0.0,>=3.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from dataclasses-json<0.5.12,>=0.5.2->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.22.0)
Requirement already satisfied: typing-inspect>=0.4.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from dataclasses-json<0.5.12,>=0.5.2->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.9.0)
Requirement already satisfied: protoc-gen-openapiv2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flyteidl>=1.13.4->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.0.1)
Requirement already satisfied: google-auth-oauthlib in /home/rakibulhasan/.local/lib/python3.10/site-packages (from gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.2.1)
Requirement already satisfied: google-cloud-storage in /home/rakibulhasan/.local/lib/python3.10/site-packages (from gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.18.2)
Requirement already satisfied: decorator>4.1.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (5.1.1)
Requirement already satisfied: google-auth>=1.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.35.0)
Requirement already satisfied: MarkupSafe>=2.0 in /usr/lib/python3/dist-packages (from jinja2<3.2,>=2.11.1->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (2.0.1)
Requirement already satisfied: pyparsing>=2.3.1 in /usr/lib/python3/dist-packages (from matplotlib<3.10,>=3.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (2.4.7)
Requirement already satisfied: cycler>=0.10 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from matplotlib<3.10,>=3.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.12.1)
Requirement already satisfied: contourpy>=1.0.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from matplotlib<3.10,>=3.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.3.0)
Requirement already satisfied: kiwisolver>=1.3.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from matplotlib<3.10,>=3.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (1.4.7)
Requirement already satisfied: fonttools>=4.22.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from matplotlib<3.10,>=3.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (4.54.1)
Requirement already satisfied: llvmlite<0.44,>=0.43.0dev0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from numba<1,>=0.56.0->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.43.0)
Requirement already satisfied: annotated-types>=0.6.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pydantic>=2->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.7.0)
Requirement already satisfied: pydantic-core==2.23.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pydantic>=2->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (2.23.4)
Requirement already satisfied: six>=1.5 in /usr/lib/python3/dist-packages (from python-dateutil>=2.8.2->pandas->flytekitplugins-deck-standard==0.0.0+develop) (1.16.0)
Requirement already satisfied: idna<4,>=2.5 in /usr/lib/python3/dist-packages (from requests>=2.18.4->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.3)
Requirement already satisfied: charset-normalizer<4,>=2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from requests>=2.18.4->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.3.2)
Requirement already satisfied: certifi>=2017.4.17 in /usr/lib/python3/dist-packages (from requests>=2.18.4->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2020.6.20)
Requirement already satisfied: aiobotocore<3.0.0,>=2.5.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from s3fs!=2024.3.1,>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.15.1)
Requirement already satisfied: patsy>=0.5.6 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from statsmodels<1,>=0.13.2->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (0.5.6)
Requirement already satisfied: attrs>=19.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from visions[type_image_path]<0.7.7,>=0.7.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (24.2.0)
Requirement already satisfied: networkx>=2.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from visions[type_image_path]<0.7.7,>=0.7.5->ydata-profiling->flytekitplugins-deck-standard==0.0.0+develop) (3.3)
Requirement already satisfied: mdurl~=0.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from markdown-it-py->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.1.2)
Collecting pygments
Downloading pygments-2.18.0-py3-none-any.whl (1.2 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 35.0 kB/s eta 0:00:00
Requirement already satisfied: botocore<1.35.24,>=1.35.16 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiobotocore<3.0.0,>=2.5.4->s3fs!=2024.3.1,>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.35.23)
Requirement already satisfied: aioitertools<1.0.0,>=0.5.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiobotocore<3.0.0,>=2.5.4->s3fs!=2024.3.1,>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.12.0)
Requirement already satisfied: wrapt<2.0.0,>=1.10.10 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiobotocore<3.0.0,>=2.5.4->s3fs!=2024.3.1,>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.16.0)
Requirement already satisfied: aiosignal>=1.1.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.3.1)
Requirement already satisfied: frozenlist>=1.1.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.4.1)
Requirement already satisfied: multidict<7.0,>=4.5 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (6.1.0)
Requirement already satisfied: async-timeout<5.0,>=4.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.0.3)
Requirement already satisfied: aiohappyeyeballs>=2.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.4.3)
Requirement already satisfied: yarl<2.0,>=1.12.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from aiohttp>=3.7.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.13.1)
Requirement already satisfied: cffi in /home/rakibulhasan/.local/lib/python3.10/site-packages (from azure-datalake-store<0.1,>=0.0.46->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.17.1)
Requirement already satisfied: msal<2,>=1.16.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from azure-datalake-store<0.1,>=0.0.46->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.31.0)
Requirement already satisfied: isodate>=0.6.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from azure-storage-blob>=12.12.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.6.1)
Requirement already satisfied: cryptography>=2.1.4 in /usr/lib/python3/dist-packages (from azure-storage-blob>=12.12.0->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.4.8)
Requirement already satisfied: pyasn1-modules>=0.2.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-auth>=1.2->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.4.1)
Requirement already satisfied: rsa<5,>=3.1.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-auth>=1.2->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (4.9)
Requirement already satisfied: cachetools<6.0,>=2.0.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-auth>=1.2->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (5.5.0)
Requirement already satisfied: mypy-extensions>=0.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from typing-inspect>=0.4.0->dataclasses-json<0.5.12,>=0.5.2->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.0.0)
Requirement already satisfied: msal-extensions>=1.2.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from azure-identity->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.2.0)
Requirement already satisfied: requests-oauthlib>=0.7.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-auth-oauthlib->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.0.0)
Requirement already satisfied: google-api-core<3.0.0dev,>=2.15.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-cloud-storage->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.20.0)
Requirement already satisfied: google-cloud-core<3.0dev,>=2.3.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-cloud-storage->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.4.1)
Requirement already satisfied: google-crc32c<2.0dev,>=1.0 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-cloud-storage->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.6.0)
Requirement already satisfied: google-resumable-media>=2.7.2 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-cloud-storage->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.7.2)
Requirement already satisfied: jmespath<2.0.0,>=0.7.1 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from botocore<1.35.24,>=1.35.16->aiobotocore<3.0.0,>=2.5.4->s3fs!=2024.3.1,>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.0.1)
Requirement already satisfied: proto-plus<2.0.0dev,>=1.22.3 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from google-api-core<3.0.0dev,>=2.15.0->google-cloud-storage->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (1.24.0)
Requirement already satisfied: PyJWT[crypto]<3,>=1.0.0 in /usr/lib/python3/dist-packages (from msal<2,>=1.16.0->azure-datalake-store<0.1,>=0.0.46->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.3.0)
Requirement already satisfied: portalocker<3,>=1.4 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from msal-extensions>=1.2.0->azure-identity->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.10.1)
Requirement already satisfied: pyasn1<0.7.0,>=0.4.6 in /home/rakibulhasan/.local/lib/python3.10/site-packages (from pyasn1-modules>=0.2.1->google-auth>=1.2->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (0.6.1)
Requirement already satisfied: oauthlib>=3.0.0 in /usr/lib/python3/dist-packages (from requests-oauthlib>=0.7.0->google-auth-oauthlib->gcsfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (3.2.0)
Requirement already satisfied: pycparser in /home/rakibulhasan/.local/lib/python3.10/site-packages (from cffi->azure-datalake-store<0.1,>=0.0.46->adlfs>=2023.3.0->flytekit->flytekitplugins-deck-standard==0.0.0+develop) (2.22)
flytekitplugins-deck-standard is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.
Installing collected packages: pygments, plotly, markdown, pandas, ydata-profiling
Successfully installed markdown-3.7 pandas-2.2.3 plotly-5.24.1 pygments-2.18.0 ydata-profiling-4.10.0

Setup process

Screenshots

Check all the applicable boxes

I updated the documentation accordingly.
All new and existing tests passed.
All commits are signed-off.

Related PRs

Docs link

welcome · 2024-10-04T13:12:07Z

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
Sign off your commits (Reference: DCO Guide).

Future-Outlier · 2024-10-04T13:17:24Z

Hi, @101rakibulhasan
Can you signoff this PR, I'll check this one, it looks good.

Signed-off-by: 101rakibulhasan <[email protected]>

101rakibulhasan · 2024-10-04T13:37:27Z

I have signed off...

Future-Outlier

Hi, @101rakibulhasan
Does pip install flytekitplugins-deck-standard still works?

101rakibulhasan · 2024-10-04T13:55:12Z

yes... but it shows the test package I installed locally ... (0.0.0+develop)
pip install flytekitplugins-deck-standard
-> Requirement already satisfied: flytekitplugins-deck-standard in /home/rakibulhasan/.local/lib/python3.10/site-packages (0.0.0+develop)

codecov · 2024-10-04T13:56:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.41%. Comparing base (f923f77) to head (2bc82a6).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f923f77) and HEAD (2bc82a6). Click for more details.

HEAD has 14 uploads less than BASE

Flag BASE (f923f77) HEAD (2bc82a6)

15 1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2786       +/-   ##
===========================================
- Coverage   93.66%   38.41%   -55.26%     
===========================================
  Files          77      195      +118     
  Lines        3712    19873    +16161     
  Branches        0     2888     +2888     
===========================================
+ Hits         3477     7635     +4158     
- Misses        235    12024    +11789     
- Partials        0      214      +214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eapolinario · 2024-10-04T14:01:34Z

plugins/flytekit-deck-standard/setup.py

@@ -6,6 +6,15 @@

 plugin_requires = ["flytekit"]

+extras = {


can you add an all that installs all dependencies? pandas is a good example of a library that does this.

I am working on it...

I just pushed the update...
Here is the output using All
-> pip install "dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl[all]"
Defaulting to user installation because normal site-packages is not writeable
Processing ./dist/flytekitplugins_deck_standard-0.0.0+develop-py3-none-any.whl
Requirement already satisfied: flytekit in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (1.13.7)
Requirement already satisfied: markdown in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (3.7)
Requirement already satisfied: pygments in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (2.18.0)
Requirement already satisfied: plotly in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (5.24.1)
Requirement already satisfied: pillow in /usr/lib/python3/dist-packages (from flytekitplugins-deck-standard==0.0.0+develop) (9.0.1)
Requirement already satisfied: ydata-profiling in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (4.10.0)
Requirement already satisfied: pandas in /home/rakibulhasan/.local/lib/python3.10/site-packages (from flytekitplugins-deck-standard==0.0.0+develop) (2.2.3)

No error was made and the extras were found

Signed-off-by: 101rakibulhasan <[email protected]>

Future-Outlier · 2024-10-04T15:26:34Z

can you run make lint and push it again with signoff?
@101rakibulhasan

Signed-off-by: 101rakibulhasan <[email protected]>

101rakibulhasan · 2024-10-04T16:38:59Z

I am actually stuck on the lint issue. I don't know how to fix it.
it only checks the file in flytekit/core and flytekit/types. I didn't touch any file there

Signed-off-by: Future-Outlier <[email protected]>

Future-Outlier · 2024-10-04T16:49:18Z

just help you do it.
Check Makefile and you will know how linters work.

101rakibulhasan · 2024-10-05T08:40:01Z

oh, I just had to use double-quotation instead of single-quotation. But the pylint & flake8 did not show any quotation related error though.
Anyway thanks for the fix <3 and I hope my contribution was acceptable.

welcome · 2024-10-08T14:52:56Z

Congrats on merging your first pull request! 🎉

…yteorg#2786) * [Flyte Deck] Extras has been added Signed-off-by: 101rakibulhasan <[email protected]> * Added "All" which will install all the libraries Signed-off-by: 101rakibulhasan <[email protected]> * Fixed linting issue using both pylint & flake8 on modified lines Signed-off-by: 101rakibulhasan <[email protected]> * fix lint Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: 101rakibulhasan <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]>

) * [Flyte Deck] Extras has been added Signed-off-by: 101rakibulhasan <[email protected]> * Added "All" which will install all the libraries Signed-off-by: 101rakibulhasan <[email protected]> * Fixed linting issue using both pylint & flake8 on modified lines Signed-off-by: 101rakibulhasan <[email protected]> * fix lint Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: 101rakibulhasan <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]>

101rakibulhasan requested review from wild-endeavor, kumare3, eapolinario, pingsutw, cosmicBboy, samhita-alla, thomasjpfan and Future-Outlier as code owners October 4, 2024 13:12

101rakibulhasan mentioned this pull request Oct 4, 2024

[Core feature] [Flyte Deck] Support 'Extra' in PIP dependency flyteorg/flyte#5805

Closed

2 tasks

[Flyte Deck] Extras has been added

2bc82a6

Signed-off-by: 101rakibulhasan <[email protected]>

101rakibulhasan force-pushed the master branch from f31f92b to 2bc82a6 Compare October 4, 2024 13:31

Future-Outlier reviewed Oct 4, 2024

View reviewed changes

eapolinario reviewed Oct 4, 2024

View reviewed changes

Added "All" which will install all the libraries

df4abbd

Signed-off-by: 101rakibulhasan <[email protected]>

101rakibulhasan force-pushed the master branch from cf4fd69 to df4abbd Compare October 4, 2024 14:19

Fixed linting issue using both pylint & flake8 on modified lines

c0f75b4

Signed-off-by: 101rakibulhasan <[email protected]>

101rakibulhasan force-pushed the master branch from 4916d84 to c0f75b4 Compare October 4, 2024 16:30

Future-Outlier previously approved these changes Oct 4, 2024

View reviewed changes

fix lint

00edc62

Signed-off-by: Future-Outlier <[email protected]>

Future-Outlier dismissed their stale review via 00edc62 October 4, 2024 16:48

Future-Outlier approved these changes Oct 7, 2024

View reviewed changes

eapolinario approved these changes Oct 8, 2024

View reviewed changes

eapolinario merged commit 11585d1 into flyteorg:master Oct 8, 2024
104 checks passed

eapolinario added the hacktoberfest-accepted label Oct 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

101rakibulhasan commented Oct 4, 2024

welcome bot commented Oct 4, 2024

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 4, 2024

Future-Outlier left a comment

101rakibulhasan commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024

eapolinario Oct 4, 2024

101rakibulhasan Oct 4, 2024

101rakibulhasan Oct 4, 2024

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 4, 2024 •

edited

Loading

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 5, 2024 •

edited

Loading

welcome bot commented Oct 8, 2024

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

Related to flyteorg/flyte#5805 [Flyte Deck] Extras has been added #2786

Conversation

101rakibulhasan commented Oct 4, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

Related PRs

Docs link

welcome bot commented Oct 4, 2024

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 4, 2024

Future-Outlier left a comment

Choose a reason for hiding this comment

101rakibulhasan commented Oct 4, 2024 • edited Loading

codecov bot commented Oct 4, 2024

Codecov Report

eapolinario Oct 4, 2024

Choose a reason for hiding this comment

101rakibulhasan Oct 4, 2024

Choose a reason for hiding this comment

101rakibulhasan Oct 4, 2024

Choose a reason for hiding this comment

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 4, 2024 • edited Loading

Future-Outlier commented Oct 4, 2024

101rakibulhasan commented Oct 5, 2024 • edited Loading

welcome bot commented Oct 8, 2024

101rakibulhasan commented Oct 4, 2024 •

edited

Loading

101rakibulhasan commented Oct 4, 2024 •

edited

Loading

101rakibulhasan commented Oct 5, 2024 •

edited

Loading