Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper bound of plugin dependencies for flytekit-sqlalchemy #2517

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Jun 19, 2024

Tracking issue

Why are the changes needed?

What changes were proposed in this pull request?

remove upper bound of plugin dependencies for flytekit-sqlalchemy

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.70%. Comparing base (29662e7) to head (e823f1d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2517       +/-   ##
===========================================
- Coverage   71.79%   50.70%   -21.10%     
===========================================
  Files         182      182               
  Lines       18561    18561               
  Branches     3654     3654               
===========================================
- Hits        13326     9411     -3915     
- Misses       4592     8666     +4074     
+ Partials      643      484      -159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 5a9cee3 into flyteorg:master Jul 12, 2024
46 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
)

* remove upper Signed-off-by: Mecoli1219 <[email protected]>
Co-authored-by: Kevin Su <[email protected]>

Signed-off-by: Jan Fiedler <[email protected]>
mao3267 pushed a commit to mao3267/flytekit that referenced this pull request Jul 29, 2024
…yteorg#2517)

* remove upper Signed-off-by: Mecoli1219 <[email protected]>
Co-authored-by: Kevin Su <[email protected]>

Signed-off-by: mao3267 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants