Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sql_alchemy plugin doesn't support pandas version > 2.1.4 #5031

Closed
2 tasks done
Future-Outlier opened this issue Mar 10, 2024 · 4 comments
Closed
2 tasks done
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers plugins Plugins related labels (backend or frontend)

Comments

@Future-Outlier
Copy link
Member

Describe the bug

When using sql alchemy plugin example from here.
https://docs.flyte.org/en/latest/flytesnacks/examples/sql_plugin/sql_alchemy.html#sql-alchemy
And using latest pandas version by pip install -U pandas.
python sql_example.py
We will meet a bug.
image
For more details, you can refer this PR.
flyteorg/flytekit#2249

Expected behavior

No bug.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Future-Outlier Future-Outlier added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers good first issue Good for newcomers and removed untriaged This issues has not yet been looked at by the Maintainers labels Mar 10, 2024
@Future-Outlier Future-Outlier changed the title [BUG] sql_alchemy plugin doesn't support pandas version <= 2.1.4 [BUG] sql_alchemy plugin doesn't support pandas version > 2.1.4 Mar 10, 2024
@flyteorg flyteorg deleted a comment from dosubot bot Mar 10, 2024
@pingsutw pingsutw added plugins Plugins related labels (backend or frontend) flytekit FlyteKit Python related issue labels Mar 12, 2024
@ChengyanOo
Copy link

Hi @Future-Outlier, I'd love to work on this issue, could you assign it to me?

@Future-Outlier
Copy link
Member Author

Hi @Future-Outlier, I'd love to work on this issue, could you assign it to me?

first come first serve

@ChengyanOo
Copy link

Hi @Future-Outlier, I'd love to work on this issue, could you assign it to me?

first come first serve

Oh got it, I thought no one is working on this😅

@Terryhung
Copy link
Contributor

Hi @Future-Outlier , I noticed that another PR: flyteorg/flytekit#2517 has removed the pandas restriction that you had previously added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flytekit FlyteKit Python related issue good first issue Good for newcomers plugins Plugins related labels (backend or frontend)
Projects
None yet
Development

No branches or pull requests

4 participants