Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default_project in register_launch_plan #2215

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add default_project in register_launch_plan #2215

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1746d8
Add default_project in register_launch_plan
ChungYujoyce Feb 26, 2024
167df55
Merge branch 'master' of github.com:flyteorg/flytekit into fix-defaul…
pingsutw Feb 29, 2024
e19fa0b
lint
pingsutw Mar 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,12 @@
:param options:
:return:
"""
ss = SerializationSettings(image_config=ImageConfig(), project=project, domain=domain, version=version)
ss = SerializationSettings(

Check warning on line 984 in flytekit/remote/remote.py

View check run for this annotation

Codecov / codecov/patch

flytekit/remote/remote.py#L984 

Added line #L984 was not covered by tests
image_config=ImageConfig(),
project=project or self.default_project,
domain=domain or self.default_domain,
version=version,
)

ident = self._resolve_identifier(ResourceType.LAUNCH_PLAN, entity.name, version, ss)
m = OrderedDict()
Expand Down
Loading