Add default_project in register_launch_plan
#2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ChungYujoyce <[email protected]>
ChungYujoyce
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:XS
ChungYujoyce
changed the title
default_project in register_launch_plan
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
==========================================
+ Coverage 85.84% 85.99% +0.14%
==========================================
Files 314 320 +6
Lines 24021 24246 +225
Branches 3639 3666 +27
==========================================
+ Hits 20621 20850 +229
+ Misses 2759 2745 -14
- Partials 641 651 +10 ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Feb 29, 2024
…t-project-register-lp
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Mar 3, 2024
eapolinario
approved these changes
Mar 4, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Add default_project in register_launch_plan Signed-off-by: ChungYujoyce <[email protected]> * lint Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: ChungYujoyce <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#4889
Why are the changes needed?
Use
default_projectanddefault_domainwhen users don't setupprojectanddomaininregister_launch_planWhat changes were proposed in this pull request?
Add
self.default_projectandself.default_domaininSerializationSettingsinitialization.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link