-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shutil instead of setuptools/distutils to copy dirs #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario and
pingsutw
as code owners
November 22, 2022 20:18
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
use shutil instead of setuptools to copy dirs
use shutil instead of setuptools/distutils to copy dirs
Nov 22, 2022
wild-endeavor
changed the title
use shutil instead of setuptools/distutils to copy dirs
Use shutil instead of setuptools/distutils to copy dirs
Nov 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
==========================================
- Coverage 70.41% 69.01% -1.41%
==========================================
Files 291 291
Lines 25594 26679 +1085
Branches 2129 2513 +384
==========================================
+ Hits 18023 18413 +390
- Misses 7083 7772 +689
- Partials 488 494 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
previously approved these changes
Nov 25, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The bump up recently to setuptools version from 65.5.1 to 65.6.0 caused one of our click unit tests to fail - some interaction between the directory copy utility provided by setuptools.distutils and the python logging library.
Getting around this by using shutil instead.
Also realized that
FlyteSchema
transformers doesn't currently handle well youFlyteSchema
instance will) by the type engine. Something to fix for the future.Type
Are all requirements met?
Tracking Issue