nits

Signed-off-by: Yee Hing Tong <[email protected]>
flyteorg · Nov 28, 2022 · 5c37326 · 5c37326
1 parent f0df00b
commit 5c37326
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/flytekit/core/data_persistence.py b/flytekit/core/data_persistence.py
@@ -36,7 +36,7 @@
 
 from flytekit.configuration import DataConfig
 from flytekit.core.utils import PerformanceTimer
-from flytekit.exceptions.user import FlyteAssertion
+from flytekit.exceptions.user import FlyteAssertion, FlyteValueException
 from flytekit.interfaces.random import random
 from flytekit.loggers import logger
 
@@ -232,7 +232,7 @@ def copy_tree(self, from_path: str, to_path: str):
             tp = pathlib.Path(self.strip_file_header(to_path))
             if tp.exists():
                 if not tp.is_dir():
-                    raise ValueError("not a dir")
+                    raise FlyteValueException(tp, f"Target {tp} exists but is not a dir")
                 files = os.listdir(tp)
                 if len(files) != 0:
                     logger.debug(f"Deleting existing target dir {tp} with files {files}")

diff --git a/tests/flytekit/unit/core/test_workflows.py b/tests/flytekit/unit/core/test_workflows.py
@@ -316,7 +316,6 @@ def schema_to_sd_wf() -> (pd.DataFrame, pd.DataFrame):
 
 
 def test_structured_dataset_wf():
-    # res = sd_to_schema_wf()
     assert_frame_equal(sd_wf(), subset_df)
     assert_frame_equal(sd_to_schema_wf(), superset_df)
     assert_frame_equal(schema_to_sd_wf()[0], subset_df)