[Snyk] Upgrade info.picocli:picocli from 4.6.3 to 4.7.0 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narape
force-pushed
the
snyk-upgrade-e2b9b9fb2ea648d1052bb85fd80748bf
branch
from
e69cf40 to
05a3d9e
Compare
narape
reviewed
Nov 28, 2022
| @@ -64,7 +64,8 @@ protected CommandLine.Model.OptionSpec getOption(String name, Variable variable) | |||
| CommandLine.Model.OptionSpec.Builder builder = | |||
| CommandLine.Model.OptionSpec.builder("--" + name) | |||
| .converters(getLiteralTypeConverter(name, variable)) | |||
| .required(defaultValue == null); | |||
| .required(defaultValue == null) | |||
| .type(Literal.class); | |||
There was a problem hiding this comment.
There was a change in picocli that if command line args are not typed then they would defualt to booleans. Without this, they test failed because the literal value returned by the converted couldn't be cast to boolean
Me amending commit from Snyk to be able to sign the commit Snyk has created this PR to upgrade info.picocli:picocli from 4.6.3 to 4.7.0. See this package in Maven Repository: https://mvnrepository.com/artifact/info.picocli/picocli/ See this project in Snyk: https://app.snyk.io/org/flyte/project/80889f34-24f9-4915-9df5-0cb18af795d6?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
Signed-off-by: Nelson Arapé <[email protected]>
narape
force-pushed
the
snyk-upgrade-e2b9b9fb2ea648d1052bb85fd80748bf
branch
from
b354265 to
fd0e227
Compare
honnix
approved these changes
Nov 28, 2022
RRap0so
approved these changes
Nov 28, 2022
andresgomezfrr
pushed a commit
that referenced
this pull request
Jan 24, 2023
* fix: upgrade info.picocli:picocli from 4.6.3 to 4.7.0 Me amending commit from Snyk to be able to sign the commit Snyk has created this PR to upgrade info.picocli:picocli from 4.6.3 to 4.7.0. See this package in Maven Repository: https://mvnrepository.com/artifact/info.picocli/picocli/ See this project in Snyk: https://app.snyk.io/org/flyte/project/80889f34-24f9-4915-9df5-0cb18af795d6?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: Nelson Arapé <[email protected]> * Fix formatting Signed-off-by: Nelson Arapé <[email protected]> * Fix picocli breaking changes Signed-off-by: Nelson Arapé <[email protected]> Signed-off-by: Nelson Arapé <[email protected]> Co-authored-by: Nelson Arapé <[email protected]> Co-authored-by: Nelson Arapé <[email protected]> Signed-off-by: Andres Gomez Ferrer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade info.picocli:picocli from 4.6.3 to 4.7.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs