[Snyk] Upgrade info.picocli:picocli from 4.6.3 to 4.7.0 (#149)

* fix: upgrade info.picocli:picocli from 4.6.3 to 4.7.0 Me amending commit from Snyk to be able to sign the commit Snyk has created this PR to upgrade info.picocli:picocli from 4.6.3 to 4.7.0. See this package in Maven Repository: https://mvnrepository.com/artifact/info.picocli/picocli/ See this project in Snyk: https://app.snyk.io/org/flyte/project/80889f34-24f9-4915-9df5-0cb18af795d6?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: Nelson Arapé <[email protected]> * Fix formatting Signed-off-by: Nelson Arapé <[email protected]> * Fix picocli breaking changes Signed-off-by: Nelson Arapé <[email protected]> Signed-off-by: Nelson Arapé <[email protected]> Co-authored-by: Nelson Arapé <[email protected]> Co-authored-by: Nelson Arapé <[email protected]> Signed-off-by: Andres Gomez Ferrer <[email protected]>
flyteorg · Jan 24, 2023 · 9e2a333 · 9e2a333
1 parent 8764231
commit 9e2a333
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/jflyte/src/main/java/org/flyte/jflyte/ExecuteLocalArgsParser.java b/jflyte/src/main/java/org/flyte/jflyte/ExecuteLocalArgsParser.java
@@ -64,7 +64,8 @@ protected CommandLine.Model.OptionSpec getOption(String name, Variable variable)
     CommandLine.Model.OptionSpec.Builder builder =
         CommandLine.Model.OptionSpec.builder("--" + name)
             .converters(getLiteralTypeConverter(name, variable))
-            .required(defaultValue == null);
+            .required(defaultValue == null)
+            .type(Literal.class);
 
     if (defaultValue != null) {
       builder.defaultValue(defaultValue);

diff --git a/jflyte/src/test/java/org/flyte/jflyte/ExecuteLocalArgsParserTest.java b/jflyte/src/test/java/org/flyte/jflyte/ExecuteLocalArgsParserTest.java
@@ -228,7 +228,7 @@ public void testParseInputs_missingArgument() {
             CommandLine.ParameterException.class,
             () -> parseInputs(ImmutableMap.of("arg", createVar(SimpleType.STRING)), new String[0]));
 
-    assertEquals("Missing required option: '--arg'", exception.getMessage());
+    assertEquals("Missing required option: '--arg=PARAM'", exception.getMessage());
   }
 
   @Test

diff --git a/pom.xml b/pom.xml
@@ -90,7 +90,7 @@
     <!-- must be aligned with netty version -->
     <!-- see: https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty -->
     <netty.tcnative.version>2.0.52.Final</netty.tcnative.version>
-    <picocli.version>4.6.3</picocli.version>
+    <picocli.version>4.7.0</picocli.version>
     <protobuf.version>3.21.7</protobuf.version>
     <sl4j.version>1.7.36</sl4j.version>
     <spotless.version>2.21.0</spotless.version>