Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/doors): disallow opening doors in mid-flight #9104

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix(a380x/doors): disallow opening doors in mid-flight #9104

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84d5136
fix: door opening pressure
2hwk Oct 20, 2024
4af5caf
Merge branch 'master' into 2c-cabin-door-delta-pressure
2hwk Oct 22, 2024
3b63098
Merge branch 'master' into 2c-cabin-door-delta-pressure
2hwk Oct 22, 2024
314ce9c
Merge branch 'master' into 2c-cabin-door-delta-pressure
flogross89 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...raft-a380-842/SimObjects/AirPlanes/FlyByWire_A380_842/model/behaviour/door_animations.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
</UseTemplate>
<UseTemplate Name="ASOBO_GT_Interaction_LeftSingle_Leave_Code">
<LEFT_SINGLE_CODE>
#TOGGLE_ID# (&gt;K:TOGGLE_AIRCRAFT_EXIT)
(L:A32NX_PRESS_MAN_CABIN_DELTA_PRESSURE, psi) 0.8 &lt; (A:INTERACTIVE POINT OPEN:#ID#, Percent) 0 &gt; || if{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, this should never happen that the cabin is pressurized and the door is open, however this condition allows for correcting possible bugs where if the plane spawns with the door open (and cabin is pressurized), that the door can still be closed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the pressurization simulation reads all door states, this will never happen as you would get cabin decompression if a door is open with delta P > 0. But since that's still not done, this looks good to me.

#TOGGLE_ID# (&gt;K:TOGGLE_AIRCRAFT_EXIT)
}
</LEFT_SINGLE_CODE>
<TOOLTIPID>A380X.TOOLTIPS.DOORS_OPEN_CLOSE</TOOLTIPID>
</UseTemplate>
Expand All @@ -24,7 +26,9 @@
</UseTemplate>
<UseTemplate Name="ASOBO_GT_Interaction_LeftSingle_Leave_Code">
<LEFT_SINGLE_CODE>
#TOGGLE_ID# (&gt;K:TOGGLE_AIRCRAFT_EXIT)
(L:A32NX_PRESS_MAN_CABIN_DELTA_PRESSURE, psi) 0.8 &lt; (A:INTERACTIVE POINT OPEN:#ID#, Percent) 0 &gt; || if{
#TOGGLE_ID# (&gt;K:TOGGLE_AIRCRAFT_EXIT)
}
</LEFT_SINGLE_CODE>
<TOOLTIPID>A380X.TOOLTIPS.DOORS_ARM_DISARM</TOOLTIPID>
</UseTemplate>
Expand Down