Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/doors): disallow opening doors in mid-flight #9104

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

2hwk
Copy link
Member

@2hwk 2hwk commented Oct 20, 2024

Fixes #[issue_no]

Summary of Changes

Blocks door from opening above a certain positive pressure difference between cabin and outside.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): 2cas

Testing instructions

  • Takeoff and reach altitude of 3000 FT
  • Check delta pressure (either on cruise SD page, or by pressing PRESS) is above 1.0
  • Attempt to open a cabin door (go into the cabin and click the lever)
  • Door should not open

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@2hwk 2hwk added A380X Related to the A380X aircraft 3D Model 3D model is wrong/something is missing QA Tier 1 QA A380 Only QA only for A380 required Needs Code Review labels Oct 20, 2024
@@ -11,7 +11,9 @@
</UseTemplate>
<UseTemplate Name="ASOBO_GT_Interaction_LeftSingle_Leave_Code">
<LEFT_SINGLE_CODE>
#TOGGLE_ID# (&gt;K:TOGGLE_AIRCRAFT_EXIT)
(L:A32NX_PRESS_MAN_CABIN_DELTA_PRESSURE, psi) 0.8 &lt; (A:INTERACTIVE POINT OPEN:#ID#, Percent) 0 &gt; || if{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, this should never happen that the cabin is pressurized and the door is open, however this condition allows for correcting possible bugs where if the plane spawns with the door open (and cabin is pressurized), that the door can still be closed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the pressurization simulation reads all door states, this will never happen as you would get cabin decompression if a door is open with delta P > 0. But since that's still not done, this looks good to me.

@JasonO99
Copy link

JasonO99 commented Oct 20, 2024

Quality Assurance Report
Completing to support QA on A380X PR's

Object of Testing:
Aircraft: A380X
Date: 20/10/2024

Testing Process
On the ground opened front most doors with lever from within cabin to ensure doors still open when valid conditions to do so

Taken off and reached altitude of 3000FT
Delta Pressure at 3000FT showed 1.4
Entered cabin using cockpit free cam again and clicked on lever on front L1 and R1 doors. Nothing happened upon clicking lever - lever and door did not animate

Positives: Doors did not open during defined testing conditions as expected
Negatives: None noted

Testing Results: Passed

@flogross89 flogross89 merged commit af6f247 into flybywiresim:master Oct 24, 2024
7 checks passed
flogross89 added a commit to flogross89/aircraft that referenced this pull request Oct 24, 2024
flogross89 pushed a commit that referenced this pull request Oct 24, 2024
fix: door opening pressure

Co-authored-by: flogross89 <[email protected]>
(cherry picked from commit af6f247)
@flogross89 flogross89 added this to the v0.12.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Model 3D model is wrong/something is missing A380X Related to the A380X aircraft QA A380 Only QA only for A380 required QA Passed QA Tier 1
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants