feat(efb/fbw): Support for TO/GA button built into the throttle (not on axis)

[ImmortalCake]

Fixes #8246

Summary of Changes

Added an option for users with devices with a TO/GA button built into the throttle. "TO/GA On Axis" can be disabled via the throttle configuration page of the EFB, in which case "increase throttle" and "increase throttle (small)" will activate and deactivate TO/GA respectively.

This change introduces a new ThrottleConfiguration.ini field: "toga_on_axis".

Screenshots (if necessary)

EFB Throttle Configuration Before:

EFB Throttle Configuration After:

References

For those without a Turtle Beach VelocityOne flight stick, here's what the throttles look like. "TO/GA UP" and "FULL REV" are buttons.

Additional context

Discord username (if different from GitHub): immortalcake

Testing instructions

This ought to be tested with any throttle device you have, including controllers, to make sure compatibility hasn't been broken. For the Turtle Beach VelocityOne, setup your bindings as follows:

• Throttle 1 Increase (Small) - Joystick Button 9 (on release)

• Throttle 1 Increase - Joystick Button 9 (on press)

• Throttle 1 Decrease - Joystick Button 10 (on press)

• Throttle 1 Cut - Joystick Button 10 (on release)

• Throttle 1 Axis - Joystick R-Axis Z (not reversed)

• Throttle 2 Increase (Small) - Joystick Button 11 (on release)

• Throttle 2 Increase - Joystick Button 11 (on press)

• Throttle 2 Decrease - Joystick Button 12 (on press)

• Throttle 2 Cut - Joystick Button 12 (on release)

• Throttle 2 Axis - Joystick Slider Y (not reversed)

On the EFB Throttle Configuration page, disable TO/GA On Axis, and set FLEX/MCT so it's upper bound is 1.00.

Test that the throttle moves between IDLE and FLEX/MCT on the axis, that reverse thrust is activated using the reverse button, and that TO/GA is activated using the TO/GA button.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, click on the bottom PR tab
4. Click on the A32NX download link at the bottom of the page

[banban60]

Hey, I would really need this function, because I'm in the same situation as the OP.
Will it be added soon, or is it completely discontinued ?

[ImmortalCake]

Hey, I would really need this function, because I'm in the same situation as the OP.
Will it be added soon, or is it completely discontinued?

It's just awaiting further quality assurance at the moment, and it's planned for release 1.12, which is probably months away.

In the meantime you can clone this fork and build it from source

[Saschl]

It will land on development version right when it is merged. I think this will also need a doc update.
@tracernz are all your concerns addressed?

[alepouna]

Waiting for the green checkmark and can QA. Feel free to @ me on discord QA channels when its ready.

[tracernz]

Concerns seem to be addressed. Please fix the changelog.

[Saschl]

Quality Assurance Report

Discord : saschl
Object of testing: #8427
Tier of Testing : 2
Date : 13/1/2024

Testing Process:

Note: used TCA throttle and keyboard for testing

1. Performed several flights with this PR and could not see any regression with my existing config. TO/GA on axis was on by default.
2. Disabled "TO/GA" on axis and reverser on axis and set FLEX/MCT so it's upper bound is 1.00. Full throttle will now enable FLEX/MCT thrust.
3. Used keyboard binding "INCREASE THROTTLE" to achieve TO/GA thrust.
4. Min throttle will set the engines to idle, "DECREASE THROTTLE" binding will activate reverse thrust.

Conclusion:
Passed

Media:

Microsoft.Flight.Simulator.2024-01-13.01-14-47.mp4

[Popespice]

Quality Assurance Trainee Report

Discord : Popespice
Object of testing: #8247
Tier of Testing : 1
Date : 16/1/2024

Testing Process:

1. Log into sim
2. Manually map TOGA function in settings to any available button on TCA Flightstick
3. Load into any airport with A32NX
4. Start up as normal
5. Take off, pressing newly mapped TOGA button
6. Observe TOGA engages as expected

Conclusion:
Working as expected

Test results:
Passed

Media:
N/A