feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit #7866

juliansebline · 2023-03-13T00:36:40Z

Summary of Changes

This PR makes all buttons on ACP and RMPs work and AudioSwitching knob too.

Plus, it adds an option in the EFB making the player able to choose on which side he/she is playing. This is mainly for shared cockpit purposes. By default, the option is set to "BOTH" which means each action on one ACP is performed onto the two other ones.

You have to understand the concept:

"Captain" means any action on FO's ACP has no effect. If the AudioSwitching knob is rotated on Captain, ACP3 is preferred. If Rotated on F/O, no effect.
"FO" means any action on Captain's ACP has no effect. If the AudioSwitching knob is rotated on F/O, ACP3 is preferred. If Rotated on Captain, no effect.

Most of the logic been rewritten to Rust. This will be useful when failures come but more importantly, the code is meant to be usable by the 380.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): julian_fbw

Testing instructions

COMM.txt

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

To better spot the changes during the tests...

Set all knobs to 0 on CPT side
Set all knobs to 100 on FO side
Start the APU

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

Understood

Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs
In the EFB, select Captain
- The simvars should now be set with Captain's ACP configuration
Rotate VHF1 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on Captain's ACP
- The knob of this ACP only should be changing

There's a bug in the SDK or at least unwanted behaviour

COM RECEIVE:1 remains at 1 if corresponding transmit button is on
COM RECEIVE:1 goes to 0 if transmit button is off

Push VHF1 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off

There's a bug in the SDK or at unwanted behaviour

COM RECEIVE:1 goes to 1 if transmit button is on even if the knob is off
COM RECEIVE:1 goes to knob position if transmit button is off

Rotate VHF2 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on Captain's ACP
- The knob of this ACP only should be changing

There's a bug in the SDK or at least unwanted behaviour

COM RECEIVE:2 remains at 1 if corresponding transmit button is on
COM RECEIVE:2 goes to 0 if transmit button is off

Push VHF2 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off

There's a bug in the SDK or at unwanted behaviour

COM RECEIVE:2 goes to 1 if transmit button is on even if the knob is off
COM RECEIVE:2 goes to knob position if transmit button is off

Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
- The buttons of this ACP only should be changing
- Simvar PILOT TRANSMITTER TYPE == 4
Keep pressing PA transmit button with left mouse button
- PA push button should be on on Captain's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on Captain's ACP only
Right click on it
- The switch should remain in this position on Captain's ACP only
Left click on it
- The switch should return to middle position on Captain's ACP only
Hold Right click on it
- The switch should go to bottom position on Captain's ACP
Release the right click
- The switch should return to middle position on Captain's ACP
Rotate the AudioSwitching knob to Captain
Restart at point 3 of this part but replace Captain's ACP with ACP3
- Passed
Rotate the AudioSwitching knob to FO
- The simvars should now be set with Captain's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

Understood

Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
In the EFB, select FO
- The simvars should now be set with FO's ACP configuration
Rotate VHF1 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE EX1:1 should update accordingly
Push VHF1 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off
Rotate VHF2 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE EX1:2 should update accordingly
Push VHF2 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off
Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
- The buttons of this ACP only should be changing
- Simvars COPILOT TRANSMITTER TYPE == 4
Keep pressing PA transmit button with left mouse button
- PA push button should be on on FO's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars PILOT TRANSMITTER TYPE == 4 if on, previous channel if off
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on FO's ACP only
Right click on it
- The switch should remain in this position on FO's ACP only
Left click on it
- The switch should return to middle position on FO's ACP only
Hold Right click on it
- The switch should go to bottom position on FO's ACP
Release the right click
- The switch should return to middle position on FO's ACP
Rotate the AudioSwitching knob to FO
Restart at point 3 of this part but replace FO's ACP with ACP3
- Passed
Rotate the AudioSwitching knob to Captain
- The simvars should now be set with FO's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change
In the EFB, select BOTH
- ALL ACPs should be updated with FO's configuration as it was the last one used

####### ELECTRICITY CHECK #######

Turn off the engines
- Only the ACPs and RMP1 should be on
Press the buttons and knobs
- Only VHF1 simvars should get updated
Turn off one battery and press many buttons on the ACPs
Turn on the APU
- The facade of each ACPs should not have changed

####### MORSE CHECK #######

For this you will have to open the behaviors window and local variables tab.

For each VOR knob, press it, rotate it copy 883636401 in the VOR1/2_IDENT_PACKEDLvar
- You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
- "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
For each ADF knob, press it, rotate itn copy 883636401 in the ADF1/2_IDENT_PACKED Lvar
- You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
- "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
For the ILS knob, press it, rotate it copy 883636401 in the ILS_IDENT_PACKED Lvar and press the onside LS button on the FCU
- You should be hearing multiple beeps and squelch and squelch only if the lvar is empty
- "BRIS" is the code. "-... .-. .. ... --.-" is what you should be hearing
Check also the sides are independant like in the previous steps.

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the left side, click on the bottom PR tab
Click on the A32NX download link at the bottom of the page

alexr4339 · 2023-03-15T13:15:10Z

Quality Assurance Tester Report

Discord : Alex R#6663
Object of testing: PR #7866
Tier of Testing : 1
Date : started on 15/03/2023 ended 19/03/2023

Testing Process:
Still in progress.
All items until F/O have been tested. A checked items means no issues were found and it behaved as expected. If an item is unchecked, I have added a small explanation of the error after the dash.

####### BOTH SIDES #######

Download the file below and rename it COMM.simvars
COMM.txt
Open the simvar watcher and load the file
Spawn on the runway
Check if the AudioSwitching knob on the overhead panel is set to NORM
Turn on the EFB and go to the simulation options
- Last line (Captain, FO, Both) set to "Both"
  For verification: Its called cockpit seat to control - Captain/Copilot/Synchronized in the EFB
Rotate VHF1 volume knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on all ACPs (including overhead)
- All related knobs should be on/off (as the option is set to Both)
- COM RECEIVE:1 should update accordingly - Added COM RECEIVE on simvarwatcher using add request button. Added Index 0-3. Index 0 had value 0, 1-3 had value 1.
Push VHF1 transmit button
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 0 if on, 4 if off
Rotate VHF2 volume knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
- COM VOLUME:2 simvar should update accordingly
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
Push VHF2 knob of all ACPs (including overhead)
- All related knobs should be on/off (as the option is set to Both)
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button
- VHF1 transmit buttons should go off
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
Rotate HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
Push HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
- All knobs should be on/off (as the option is set to Both)
Push HF1, HF2, Mech, Cab transmit buttons on all ACPs (except PA)
- All buttons should be on/off (as the option is set to Both)
- Only one transmit button can be on at a time
Keep pressing PA transmit button with left mouse button
- Only PA push button should be on on all ACPs
- Release the mouse button, the light should return to the previous selected channel
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on all ACPs
Right click on it
- The switch should remain in this position on all ACPs
Left click on it
- The switch should return to middle position on all ACPs
Hold Right click on it
- The switch should go to bottom position on all ACPs
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
Release the right click
- The switch should return to middle position on all ACPs
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 0

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

Understood

Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs -Not possible as long as EFB was set to both. Setting FB to captain. I am now able set to different values as other ACP.
In the EFB, select Captain
- The simvars should now be set with Captain's ACP configuration - Side note: Turning VHF3 knob has no effect on COM VOLUME:3. Neither in captain nor in synchronized and is always 1.
Rotate VHF1 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on Captain's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:1 should update accordingly - Value is always 1 when vhf1 transmit is on. If transmit is off (pilot type = 4) then it updates correctly.
Push VHF1 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
Rotate VHF2 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on Captain's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
- The buttons of this ACP only should be changing
Keep pressing PA transmit button with left mouse button
- PA push button should be on on Captain's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars PILOT TRANSMITTER TYPE = 8 if on, previous channel if off and COPILOT TRANSMITTER TYPE = 4
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on Captain's ACP only
- Simvars PILOT TRANSMITTER TYPE = 6 and COPILOT TRANSMITTER TYPE = 4
Right click on it
- The switch should remain in this position on Captain's ACP only
Left click on it
- The switch should return to middle position on Captain's ACP only
- Simvars PILOT TRANSMITTER TYPE = current transmit channel and COPILOT TRANSMITTER TYPE = 4
Hold Right click on it
- The switch should go to bottom position on Captain's ACP
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
Release the right click
- The switch should return to middle position on Captain's ACP
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
Rotate the AudioSwitching knob to Captain
Restart at point 3 of this part but replace Captain's ACP with ACP3
- Passed - Same behaviour and same issues as with acp1.
Rotate the AudioSwitching knob to FO
- The simvars should now be set with Captain's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

Understood

Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
In the EFB, select FO
- The simvars should now be set with FO's ACP configuration
Rotate VHF1 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:1 should update accordingly - com receive only updates from 0 to 1 if vhf1 call button is not illuminated. If call button is illuminated, COM RECEIVE:1 is always 1
Push VHF1 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars COPILOT TRANSMITTER TYPE = 0 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
Rotate VHF2 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars COPILOT TRANSMITTER TYPE = 1 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
- The buttons of this ACP only should be changing
Keep pressing PA transmit button with left mouse button
- PA push button should be on on FO's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars COPILOT TRANSMITTER TYPE = 8 if on, previous channel if off and PILOT TRANSMITTER TYPE = 4
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on FO's ACP only
- Simvars COPILOT TRANSMITTER TYPE = 6 and PILOT TRANSMITTER TYPE = 4
Right click on it
- The switch should remain in this position on FO's ACP only
Left click on it
- The switch should return to middle position on FO's ACP only
- Simvars COPILOT TRANSMITTER TYPE = current transmit channel and PILOT TRANSMITTER TYPE = 4
Hold Right click on it
- The switch should go to bottom position on FO's ACP
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
Release the right click
- The switch should return to middle position on FO's ACP
- Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
Rotate the AudioSwitching knob to FO
Restart at point 3 of this part but replace FO's ACP with ACP3
- Passed - ACP3 had same issue as ACP2
Rotate the AudioSwitching knob to Captain
- The simvars should now be set with FO's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change
In the EFB, select BOTH
- ALL ACPs should be updated with FO's configuration as it was the last one used

Negatives:
N/A

Testing Results:
Passed

Conclusions:
Everything works as expected.

2hwk · 2023-03-30T15:01:06Z

Fix merge conflicts ^^

juliansebline · 2023-03-30T15:04:31Z

Fix merge conflicts ^^

Wilco once at home this weekend

fbw-a32nx/src/behavior/src/A32NX_Interior_EFIS.xml

fbw-a32nx/docs/a320-simvars.md

resolved

alepouna · 2023-07-15T17:16:34Z

QA Report

Discord: alepouna
Object of testing: #7866
Tier of Testing : 1
Date : 25/6/2023

Testing Process:

####### BOTH SIDES #######

Download the file below and rename it COMM.simvars
COMM.txt
Open the simvar watcher and load the file
Spawn on the runway
Check if the AudioSwitching knob on the overhead panel is set to NORM
Turn on the EFB and go to the simulation options
- Last line (Captain, FO, Both) set to "Both"
Rotate VHF1 volume knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on all ACPs (including overhead)
- All related knobs should be on/off (as the option is set to Both)
- COM RECEIVE:1 should update accordingly
Push VHF1 transmit button
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 0 if on, 4 if off
Rotate VHF2 volume knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
- COM VOLUME:2 simvar should update accordingly
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
Push VHF2 knob of all ACPs (including overhead)
- All related knobs should be on/off (as the option is set to Both)
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button
- VHF1 transmit buttons should go off
- PILOT TRANSMITTER TYPE and COPILOT TRANSMITTER TYPE simvars should be set to 1 if on, 4 if off
Rotate HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
- All related knobs should rotate and be at the same position (as the option is set to Both)
Push HF1, HF2, Mech, Cab and PA knob on all ACPs (including overhead)
- All knobs should be on/off (as the option is set to Both)
Push HF1, HF2, Mech, Cab transmit buttons on all ACPs (except PA)
- All buttons should be on/off (as the option is set to Both)
- Only one transmit button can be on at a time
Keep pressing PA transmit button with left mouse button
- Only PA push button should be on on all ACPs
- Release the mouse button, the light should return to the previous selected channel
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on all ACPs
Right click on it
- The switch should remain in this position on all ACPs
Left click on it
- The switch should return to middle position on all ACPs
Hold Right click on it
- [NOT PASSED - LEGACY CONTROLS INOP | OP for other control method] The switch should go to bottom position on all ACPs
- [ref above] Lvar IS_EMITTING_ON_FREQUENCY simvar should be set to 1
Release the right click
- [ref 20] The switch should return to middle position on all ACPs
- [ref 20] Lvar IS_EMITTING_ON_FREQUENCY simvar should be set to 0

####### CAPTAIN SIDE: The controlling ACPs are either ACP1 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND CAPTAIN'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON CAPTAIN.**

Understood

Turn the knobs and push the buttons on Captain's ACP to different values than the other ACPs
In the EFB, select Captain
- The simvars should now be set with Captain's ACP configuration
Rotate VHF1 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on Captain's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:1 should update accordingly
Push VHF1 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
Rotate VHF2 volume knob on Captain's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on Captain's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button on Captain's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 1 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
Rotate HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on Captain's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on Captain's ACP (except PA)
- The buttons of this ACP only should be changing
Keep pressing PA transmit button with left mouse button
- PA push button should be on on Captain's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars PILOT TRANSMITTER TYPE = 8 if on, previous channel if off and COPILOT TRANSMITTER TYPE = 4
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on Captain's ACP only
- Simvars PILOT TRANSMITTER TYPE = 6 and COPILOT TRANSMITTER TYPE = 4
Right click on it
- [ref 20 from first set] The switch should remain in this position on Captain's ACP only
Left click on it
- The switch should return to middle position on Captain's ACP only
- Simvars PILOT TRANSMITTER TYPE = current transmit channel and COPILOT TRANSMITTER TYPE = 4
Hold Right click on it
- [ref 20 from first set] The switch should go to bottom position on Captain's ACP
- [ref 20 from first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
Release the right click
- [ref 20 from first set] The switch should return to middle position on Captain's ACP
- [ref 20 from first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
Rotate the AudioSwitching knob to Captain
Restart at point 3 of this part but replace Captain's ACP with ACP3
- Passed
Rotate the AudioSwitching knob to FO
- The simvars should now be set with Captain's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change

####### F/O SIDE: The controlling ACPs are either ACP2 or 3 (depending on AudioSwitching knob position) #######

** PLEASE KEEP IN MIND ACP3 SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON NORM.**

Understood

** PLEASE KEEP IN MIND FO'S ACP SHOULD HAVE NO EFFECT IF AUDIO SWITCHING KNOB ON FO.**

Understood

Turn the knobs and push the buttons on FO's ACP to different values than the other ACPs
In the EFB, select FO
- The simvars should now be set with FO's ACP configuration
Rotate VHF1 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:1 simvar should update accordingly
Push VHF1 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:1 should update accordingly
Push VHF1 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars PILOT TRANSMITTER TYPE = 0 if on, 4 if off and COPILOT TRANSMITTER TYPE = 4
Rotate VHF2 volume knob on FO's ACP
- The knob of this ACP only should be rotating
- COM VOLUME:2 simvar should update accordingly
Push VHF2 knob on FO's ACP
- The knob of this ACP only should be changing
- COM RECEIVE:2 should update accordingly
Push VHF2 transmit button on FO's ACP
- The button of this ACP only should be changing
- Simvars COPILOT TRANSMITTER TYPE = 1 if on, 4 if off and PILOT TRANSMITTER TYPE = 4
Rotate HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab and PA knob on FO's ACP
- The knobs of this ACP only should be changing
Push HF1, HF2, Mech, Cab transmit buttons on FO's ACP (except PA)
- The buttons of this ACP only should be changing
Keep pressing PA transmit button with left mouse button
- PA push button should be on on FO's ACP only
- Release the mouse button, the light should return to the previous selected channel
- Simvars COPILOT TRANSMITTER TYPE = 8 if on, previous channel if off and PILOT TRANSMITTER TYPE = 4
On each ACP, the INTRAD switch should be set to middle position
- Yes
Left click on it
- The switch should go to the top position on FO's ACP only
- Simvars COPILOT TRANSMITTER TYPE = 6 and PILOT TRANSMITTER TYPE = 4
Right click on it
- [ref 20 first set] The switch should remain in this position on FO's ACP only
Left click on it
- [ref 20 first set] The switch should return to middle position on FO's ACP only
- [ref 20 first set] Simvars COPILOT TRANSMITTER TYPE = current transmit channel and PILOT TRANSMITTER TYPE = 4
Hold Right click on it
- [ref 20 first set] The switch should go to bottom position on FO's ACP
- [ref 20 first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 1
Release the right click
- [ref 20 first set] The switch should return to middle position on FO's ACP
- [ref 20 first set] Lvar IS_EMITTING_ON_FREQUENCY should be set to 0
Rotate the AudioSwitching knob to FO
Restart at point 3 of this part but replace FO's ACP with ACP3
- [Not passed COPILOT TRANSMIT TYPE DOES NOT CHANGE] Passed
Rotate the AudioSwitching knob to Captain
- The simvars should now be set with FO's ACP configuration
Rotate the AudioSwitching knob to NORM
- Nothing should change
In the EFB, select BOTH
- [Only after changing one value - not really a negative] ALL ACPs should be updated with FO's configuration as it was the last one used

Notes:
The rotation speed for VHF 1 and 2 is fast, but for everything else (VHF 3, HF1, HF 2, INT, CAB, PA, VOR 1, VOR 2, MKR, ILS, MLS, ADF1, ADF2) is slower

Negatives:

Refer set 1 test 20: INTRAD is not able to moved to the bottom position in legacy controls, works fine on normal mode or if right click is used but not with normal controls
Refer set 3 test 23: Once Cockpit seat used to control BOTH ACPs, the values will sync AFTER at least either ACP(including 3) have a change of values, they do not change to what the captain has set when pressing the button on the EFB.

Testing Results:
Passed with remarks

fbw-a32nx/docs/a320-simvars.md

tracernz

I will leave some comments when I get a chance, but there are a few things wrong here and I wanted to register that straight away so it doesn't get merged first.

tracernz

I've had a quick scan over.

fbw-a32nx/src/behavior/src/A32NX_Interior_RMP.xml

fbw-a32nx/src/systems/instruments/src/EWD/PseudoFWC.ts

.github/CHANGELOG.md

juliansebline · 2023-07-25T10:19:36Z

I've had a quick scan over.

Thanks a lot! I'll fix all this very soon.

...bywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/model/A320_NEO_INTERIOR.xml

fbw-a32nx/src/behavior/src/A32NX_Interior_ACP.xml

…bline/a32nx into ACP_ovhd_shared_cockpit

.cargo/config.toml

fbw-a32nx/src/wasm/fbw_a320/build.sh

tracernz

I gave this a quick skim. It's been a long time and much has changed in the main project!

The captain/fo side vs AMU/RMP is implemented a little differently in the A380. It's just whichever half of the cockpit you are sitting in at the time. We should unify whatever we decide to do so the two planes work the same from the user perspective.

The A380 already has the RMPs and AMUs implemented as discrete systems with bus communication between them in typescript with failures for each component, and I was intending to bring this to the A320 digital RAIM later (3d modelling is in progress for that as well).

I've added a couple of issues that need addressed, and a couple of notes below.

tracernz · 2024-06-08T03:09:57Z

fbw-a32nx/src/systems/instruments/src/RMP/Components/BaseRadioPanels.tsx

    }
  });

+  /**
+   * MLS IMPLEMENTED IN THE XML BEHAVIOURS
+   * BUT DISABLED HERE SINCE THERE IS NOT ENOUGH REFERENCES


Note: We will never implement MLS as it's obsolete.

True! Was commented out but I suppose the rebase wasn't that successful. It's fixed.

Also, I'm keeping MLS tag since the it's written MLS everywhere in the code but it should be GLS in the future. Will it be implemented?

The GLS button is already there alongside MLS in the cockpit. GLS will be implemented in time with a new MMR implementation. I will be a bit busy for the next couple of months though. It will need external nav database support first as MSFS does not have any GLS data. Navigraph also does not provide the GLS FAS data... it's only in the latest ARINC424 standards.

tracernz · 2024-06-08T03:10:43Z

fbw-a32nx/src/systems/instruments/src/RMP/Components/NavRadioPanel.tsx


  const [APPR] = useSimVar('L:A32NX_FCU_APPR_MODE_ACTIVE', 'bool');
  const [AP] = useSimVar('L:A32NX_AUTOPILOT_ACTIVE', 'bool');
  const [RA1] = useSimVar('L:A32NX_RA_1_RADIO_ALTITUDE', 'number');
  const [RA2] = useSimVar('L:A32NX_RA_2_RADIO_ALTITUDE', 'number');
+  const [, setCourse] = useSimVar(
+    props.receiver === TransceiverType.VOR ? `K:VOR${index}_SET` : 'L:A32NX_FM_LS_COURSE',


The RMP should never write FM vars (or any other system's vars).

Then I have to refactor it now the Rust code exists

For the time being, it has to be done this way (or in Rust) since the FMGC is not complete

fbw-a32nx/src/wasm/systems/a320_systems_wasm/src/communications.rs

tracernz · 2024-06-08T03:14:27Z

fbw-common/src/wasm/systems/systems/src/communications/receivers.rs

+    fn read(&mut self, reader: &mut SimulatorReader) {
+        self.ident_new = reader.read(&self.ident_id);
+    }
+}


Note: this morse beeping would be a lot easier to do in typescript with SoundServer to play packets of sounds (https://microsoft.github.io/msfs-avionics-mirror/docs/sounds/soundserver). The underlying sound API is more comprehensive on the JS side. Ultimately it needs to be controlled/part of the NAV receivers (in C++) rather than the audio system, so it can be in sync with the simulated NAV radios and ident decoding. We can bring this in now and refactor/rewrite later.

Alright sounds good. Always down to create a better code :)

Are the NAV receivers implemented in C++ already? If not, once my PRs are merged, I could work on it

I’ve been working in the background a bit for a few months. Most of the time spent on research so far, especially for the MMR as it includes ILS, GLS, FLS, SLS, GPS, VOR and marker beacon all in the one unit 🤯. It also requires nav database work alongside.

juliansebline · 2024-06-08T03:33:54Z

I gave this a quick skim. It's been a long time and much has changed in the main project!

The captain/fo side vs AMU/RMP is implemented a little differently in the A380. It's just whichever half of the cockpit you are sitting in at the time. We should unify whatever we decide to do so the two planes work the same from the user perspective.

The A380 already has the RMPs and AMUs implemented as discrete systems with bus communication between them in typescript with failures for each component, and I was intending to bring this to the A320 digital RAIM later (3d modelling is in progress for that as well).

I've added a couple of issues that need addressed, and a couple of notes below.

Alright so what should I do? Delete this PR? 😅

tracernz · 2024-06-08T10:10:40Z

Alright so what should I do? Delete this PR? 😅

Noooo, this is good! The 2 things to address are the NAV4 being MMR2 (ILS), and the LS course var.
Anything else is future work.

juliansebline · 2024-06-09T08:11:33Z

Alright so what should I do? Delete this PR? 😅

Noooo, this is good! The 2 things to address are the NAV4 being MMR2 (ILS), and the LS course var.

Anything else is future work.

Alright! We'll discuss about it! I agree it's possible to make it more realistic.

Now I am in Greece enjoying 40 degrees C, Gyros (pita sandwich) and sea food until next Sunday

juliansebline · 2024-06-09T08:14:03Z

Anyway, in the mean time it would be a good idea to final test it and merge because it became VERY unmaintainable.

I spend too much time rebasing.

I'll create a new PR based on the updated master to address the changes

tracernz · 2024-06-15T14:45:41Z

Alright! We'll discuss about it! I agree it's possible to make it more realistic.

Now I am in Greece enjoying 40 degrees C, Gyros (pita sandwich) and sea food until next Sunday

To further clarify. While I talked about digital RAIM, we will also keep the old ACPs + RMPs as an option in the A32NX, so everything you've done for them is still 💯 . I assumed that without stating it outright before!

tracernz · 2024-10-27T15:01:34Z

.github/CHANGELOG.md

@@ -92,6 +92,7 @@
 1. [EFCS] Fix ground spoiler retraction after increasing TLA slightly above 0 - @lukecologne (luke)
 1. [FWC] Improved LDG LT memo to take into account light position - @BravoMike99 (bruno_pt99)
 1. [PRESS] Add pressurization system failures - @mjuhe (Miquel Juhe)
+1. [COMMS] Enabled all components of communications panels - @Julian [Z+2 fr en esp]#8476 (Julian Sebline)


Please rebase/merge and move to 0.13.0.

Wilco.

Been away for ages but planning to resume operations once I move to my new apartment with proper desk etc.

But it's going to be hell. Might create a new branch

Copy that, just create a draft PR and mark as ready for review when you are done.

2hwk added the Needs Code Review label Mar 19, 2023

2hwk added this to the v0.10.0 milestone Mar 19, 2023

2hwk approved these changes Mar 26, 2023

View reviewed changes

2hwk added QA Tier 2 Please Resolve Conflicts The author of thie PR must resolve remaining conflicts and removed Needs Code Review labels Mar 26, 2023

tracernz reviewed Apr 1, 2023

View reviewed changes

fbw-a32nx/src/behavior/src/A32NX_Interior_EFIS.xml Show resolved Hide resolved

2hwk removed the Please Resolve Conflicts The author of thie PR must resolve remaining conflicts label Apr 2, 2023

tracernz previously requested changes Apr 3, 2023

View reviewed changes

fbw-a32nx/docs/a320-simvars.md Outdated Show resolved Hide resolved

Saschl modified the milestones: v0.10.0, v0.11.0 Apr 18, 2023

tracernz added the Waiting on Core Decision label Jul 16, 2023

alepouna mentioned this pull request Jul 18, 2023

feat(pilots-corner): Replace RMP labels for INOP & A32NX Flightdeck API flybywiresim/docs#863

Closed

alepouna reviewed Jul 19, 2023

View reviewed changes

fbw-a32nx/docs/a320-simvars.md Outdated Show resolved Hide resolved

tracernz requested changes Jul 25, 2023

View reviewed changes

tracernz reviewed Jul 25, 2023

View reviewed changes

tracernz reviewed Aug 3, 2023

View reviewed changes

...bywire-aircraft-a320-neo/SimObjects/AirPlanes/FlyByWire_A320_NEO/model/A320_NEO_INTERIOR.xml Show resolved Hide resolved

tracernz reviewed Aug 3, 2023

View reviewed changes

fbw-a32nx/src/behavior/src/A32NX_Interior_ACP.xml Outdated Show resolved Hide resolved

tracernz removed the Waiting on Core Decision label Sep 13, 2023

juliansebline added 8 commits June 6, 2024 12:54

Rebase

3ec1e7b

Fix lint

ee3efc6

Changelog

950af18

Fix bad rebase. SimOptions disappeared

0b64fca

Fix previous commit

d3d1133

Rebase + lint

f5533b2

Merge branch 'ACP_ovhd_shared_cockpit' of https://github.com/julianse…

4d1649e

…bline/a32nx into ACP_ovhd_shared_cockpit

Fix build

9ab8b74

juliansebline commented Jun 7, 2024

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

juliansebline commented Jun 7, 2024

View reviewed changes

fbw-a32nx/src/wasm/fbw_a320/build.sh Outdated Show resolved Hide resolved

juliansebline added 2 commits June 7, 2024 13:13

Removal of unit tests

801b31c

Removal of unit tests

75fa343

juliansebline requested a review from beheh June 7, 2024 12:40

Merge branch 'master' into ACP_ovhd_shared_cockpit

3da66e2

beheh approved these changes Jun 7, 2024

View reviewed changes

tracernz requested changes Jun 8, 2024

View reviewed changes

juliansebline added 4 commits June 20, 2024 10:42

Merge branch 'master' into ACP_ovhd_shared_cockpit

c8738b6

Comments

af8843b

Disabling MLS

0594807

MMRs ILS only

7d17748

flogross89 modified the milestones: v0.12.0, v0.13.0 Oct 26, 2024

tracernz reviewed Oct 27, 2024

View reviewed changes

2hwk modified the milestones: v0.13.0, Backlog Nov 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit #7866

feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit #7866

juliansebline commented Mar 13, 2023 •

edited

Loading

alexr4339 commented Mar 15, 2023 •

edited

Loading

2hwk commented Mar 30, 2023

juliansebline commented Mar 30, 2023

alepouna commented Jul 15, 2023

tracernz left a comment

tracernz left a comment

juliansebline commented Jul 25, 2023

tracernz left a comment •

edited

Loading

tracernz Jun 8, 2024 •

edited

Loading

juliansebline Jun 20, 2024 •

edited

Loading

tracernz Jun 20, 2024 •

edited

Loading

tracernz Jun 8, 2024 •

edited

Loading

juliansebline Jun 20, 2024

juliansebline Jun 20, 2024

tracernz Jun 8, 2024 •

edited

Loading

juliansebline Jun 20, 2024 •

edited

Loading

tracernz Jun 20, 2024

juliansebline commented Jun 8, 2024

tracernz commented Jun 8, 2024 •

edited

Loading

juliansebline commented Jun 9, 2024 •

edited

Loading

juliansebline commented Jun 9, 2024 •

edited

Loading

tracernz commented Jun 15, 2024 •

edited

Loading

tracernz Oct 27, 2024

juliansebline Oct 27, 2024

juliansebline Oct 27, 2024

2hwk Nov 4, 2024

feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit #7866

Are you sure you want to change the base?

feat(acps): Rest of knobs/buttons on ACPs/RMPs, Ovhd panel and shared cockpit #7866

Conversation

juliansebline commented Mar 13, 2023 • edited Loading

Summary of Changes

Screenshots (if necessary)

References

Additional context

Testing instructions

How to download the PR for QA

alexr4339 commented Mar 15, 2023 • edited Loading

2hwk commented Mar 30, 2023

juliansebline commented Mar 30, 2023

alepouna commented Jul 15, 2023

tracernz left a comment

Choose a reason for hiding this comment

tracernz left a comment

Choose a reason for hiding this comment

juliansebline commented Jul 25, 2023

tracernz left a comment • edited Loading

Choose a reason for hiding this comment

tracernz Jun 8, 2024 • edited Loading

Choose a reason for hiding this comment

juliansebline Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

tracernz Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

tracernz Jun 8, 2024 • edited Loading

Choose a reason for hiding this comment

juliansebline Jun 20, 2024

Choose a reason for hiding this comment

juliansebline Jun 20, 2024

Choose a reason for hiding this comment

tracernz Jun 8, 2024 • edited Loading

Choose a reason for hiding this comment

juliansebline Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

tracernz Jun 20, 2024

Choose a reason for hiding this comment

juliansebline commented Jun 8, 2024

tracernz commented Jun 8, 2024 • edited Loading

juliansebline commented Jun 9, 2024 • edited Loading

juliansebline commented Jun 9, 2024 • edited Loading

tracernz commented Jun 15, 2024 • edited Loading

tracernz Oct 27, 2024

Choose a reason for hiding this comment

juliansebline Oct 27, 2024

Choose a reason for hiding this comment

juliansebline Oct 27, 2024

Choose a reason for hiding this comment

2hwk Nov 4, 2024

Choose a reason for hiding this comment

juliansebline commented Mar 13, 2023 •

edited

Loading

alexr4339 commented Mar 15, 2023 •

edited

Loading

tracernz left a comment •

edited

Loading

tracernz Jun 8, 2024 •

edited

Loading

juliansebline Jun 20, 2024 •

edited

Loading

tracernz Jun 20, 2024 •

edited

Loading

tracernz Jun 8, 2024 •

edited

Loading

tracernz Jun 8, 2024 •

edited

Loading

juliansebline Jun 20, 2024 •

edited

Loading

tracernz commented Jun 8, 2024 •

edited

Loading

juliansebline commented Jun 9, 2024 •

edited

Loading

juliansebline commented Jun 9, 2024 •

edited

Loading

tracernz commented Jun 15, 2024 •

edited

Loading