This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
get ChangeSet from outside of paths if manifest generation is enabled #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordovicia
added a commit
to ordovicia/flux
that referenced
this pull request
Apr 27, 2020
ordovicia
added a commit
to ordovicia/flux
that referenced
this pull request
Apr 27, 2020
ordovicia
added a commit
to ordovicia/flux
that referenced
this pull request
Apr 27, 2020
ordovicia
added a commit
to ordovicia/flux
that referenced
this pull request
Apr 27, 2020
|
@hiddeco @stefanprodan Could you please take a look at this and #3039? Thank you. |
squaremo
reviewed
May 12, 2020
|
@squaremo This PR is ready for merge. Is there anything I am supposed to do? |
getChangeSet() in pkg/daemon/sync.go now does not consider target paths while identifying what series of commits changed files Flux is watching when the manifest generation is enabled. With manifest generation enabled, kubernetes resources can be modified by changes in files outside of target paths. getChangeSet() now conservatively identifies commits that may have changed resources when the manifest generation is enabled.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getChangeSet()inpkg/daemon/sync.gonow does not consider target pathswhile identifying what series of commits changed files Flux is watching
when the manifest generation is enabled.
With manifest generation enabled, Kubernetes resources can be modified
by changes in files outside of target paths.
getChangeSet()now conservatively identifies commits that may havechanged resources when the manifest generation is enabled.
Fixes #3018