Testing PR #3022, #3039 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
dan-slinky-ckpd
commented
May 23, 2020
dan-slinky-ckpd
commented
- get ChangeSet from outside of paths if manifest generation is enabled fluxcd/flux#3022
- direct comparison of last-synced and newly-synced resources fluxcd/flux#3039
getChangeSet() in pkg/daemon/sync.go now does not consider target paths while identifying what series of commits changed files Flux is watching when the manifest generation is enabled. With manifest generation enabled, kubernetes resources can be modified by changes in files outside of target paths. getChangeSet() now conservatively identifies commits that may have changed resources when the manifest generation is enabled.
`getChangedResources()` in `pkg/daemon/sync.go` could not determin what resources are modified when a manifest file has multiple resource definitions. This commit replaces `getChangedResources()` with new `compareResources()` function, which determins resource updates and deletions by direct comparison of last-synced and newly-synced clones.
... instead of cloning and generating manifests on every sync, because generating manifests could be quite expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.