Add canary analysis schedule interval to CRD #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
- Coverage 50.95% 49.53% -1.42%
==========================================
Files 7 8 +1
Lines 942 969 +27
==========================================
Hits 480 480
- Misses 381 408 +27
Partials 81 81
Continue to review full report at Codecov.
|
- new field canaryAnalysis.interval
stefanprodan
changed the title
| if r.Spec.TargetRef.Kind == "Deployment" { | ||
| go c.advanceCanary(r.Name, r.Namespace) | ||
| canary := value.(*flaggerv1.Canary) | ||
| name := key.(string) |
There was a problem hiding this comment.
nit: It'd be good to have a comment to show what these keys look like, it's hard to tell from the code. I'd assume it's something like <namespace>/<name>, but I'm not sure exactly.
There was a problem hiding this comment.
Yes it's <name>.<namespace> I'll add a comment thanks!
errordeveloper
approved these changes
Jan 8, 2019
errordeveloper
approved these changes
Jan 8, 2019
- use anyOf as a workaround for the openAPI object validation not accepting empty values - fix #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the analysis schedule configurable fix: #19
The above analysis, if it succeeds, will run for 25 minutes while validating the HTTP metrics and webhooks every minute.
You can determine the minimum time that it takes to validate and promote a canary deployment using this formula:
And the time it takes for a canary to be rollback when the metrics or webhooks checks are failing: