Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary OpenAPI validation fails when not specifying a HPA ref #23

Closed
stefanprodan opened this issue Jan 11, 2019 · 2 comments
Closed

Canary OpenAPI validation fails when not specifying a HPA ref #23

stefanprodan opened this issue Jan 11, 2019 · 2 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@stefanprodan
Copy link
Member

As per kubernetes/apiextensions-apiserver#25 CRD validation doesn't accept empty values for type "object" fields.

Workaround:

            autoscalerRef:
              anyOf:
                - type: string
                - type: object
              required: ['apiVersion', 'kind', 'name']
              properties:
                apiVersion:
                  type: string
                kind:
                  type: string
                name:
                  type: string
@stefanprodan stefanprodan added the kind/bug Something isn't working label Jan 11, 2019
@stefanprodan stefanprodan self-assigned this Jan 11, 2019
@stefanprodan
Copy link
Member Author

@carlossg thanks for finding this bug. The fix will be included in Flagger v0.3.0 that comes with Canary v1alpha3. You'll have to apply the new CRD and upgrade all your canaries definitions to v1alpha3.

I'll ping you when the release is ready, thanks again 👍

@stefanprodan
Copy link
Member Author

stefanprodan commented Jan 11, 2019

@carlossg I've just released v0.3.0 besides the CRD version being bumped to v1alpha3 there is a breaking change regarding the control loop interval. The flag controlLoopInterval has been removed from the chart and now the interval can be set in the CRD using canaryAnalysis.interval (defaults to 1m).

I've documented the change here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant