Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_adaptive_scaffold] Fix top padding for NavigationBar #4661

Merged
merged 4 commits into from
Aug 22, 2023
Merged

[flutter_adaptive_scaffold] Fix top padding for NavigationBar #4661

merged 4 commits into from
Aug 22, 2023

Conversation

ctrysbita
Copy link
Contributor

@ctrysbita ctrysbita commented Aug 7, 2023 •
edited
Loading

This pr removes the top padding in MediaQuery for NavigationBar to fix unexpected padding.
The Scaffold in flutter framework actually did this but this package didn't.

Fix flutter/flutter#127088

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ctrysbita ctrysbita requested a review from gspencergoog as a code owner August 7, 2023 18:17
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ctrysbita
Copy link
Contributor Author

@gspencergoog Could you have a review on this?

@taleroangel
Copy link

The library has been broken for 3 month now. Please review this fix

@gspencergoog
Copy link
Contributor

In order to proceed with the review, this PR will need to have some tests to prevent regression in the future, as the message from the bot above describes. It just needs to be a test that fails without your change, and succeeds with your change.

@ctrysbita
Copy link
Contributor Author

@gspencergoog The tests were already updated.

gspencergoog
gspencergoog approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Sorry, I didn't notice that the change included the file in the test directory.

Piinks
Piinks approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome! Thanks for contributing!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2023
@auto-submit auto-submit bot merged commit c6f758b into flutter:main Aug 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
c6f758b [flutter_adaptive_scaffold] Fix top padding for NavigationBar (…
1316d1c 
…flutter/packages#4661)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 23, 2023
@engine-flutter-autoroll
Roll Packages from c730a90 to 3060b1a (4 revisions) (#133149)
bd836cc 
flutter/packages@c730a90...3060b1a

2023-08-23 [email protected] [rfw] Support web (as JS) (flutter/packages#4650)
2023-08-22 [email protected] [webview_flutter] Update sample code. (flutter/packages#4727)
2023-08-22 [email protected] [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661)
2023-08-22 [email protected] Remove deprecated `ImageProvider` methods (flutter/packages#4725)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_adaptive_scaffold] : Bottom Navigation bar height is too much in Flutter 3.10.1
4 participants
@ctrysbita @taleroangel @gspencergoog @Piinks