[rfw] Support web (as JS) #4650
Conversation
Hixie
force-pushed
the
rfwweb
branch
4 times, most recently
from
f2c41dc to
af60c5e
Compare
packages/rfw/CHANGELOG.md
Outdated
|
|
||
| * Improved web compatibility. |
There was a problem hiding this comment.
Nit: Improves
(Per style guide linked from the checklist.)
| @@ -264,6 +276,10 @@ RemoteWidgetLibrary decodeLibraryBlob(Uint8List bytes) { | |||
| // endianess used by this format | |||
| const Endian _blobEndian = Endian.little; | |||
|
|
|||
| // whether we can use 64 bit APIs on this platform | |||
| // (on JS, we can only use 32 bit APIs and integers only go up to ~2^53) | |||
| const bool _kHas64Bits = 0x1000000000000000 + 1 != 0x1000000000000000; // 2^60 | |||
There was a problem hiding this comment.
Nit: Effective Dart says not to use k, and Flutter style only says to use it for global constants
(I would strongly vote for changing the Flutter style guide to remove the _k... example and change "It’s not necessary to add the k prefix to non-global constants." to explicitly forbid it, to reduce pointless diff from Effective Dart.)
| // yet rolled to stable. Avoid using this to skip tests of _RFW_ features that | ||
| // aren't compatible with stable. Those should wait until the stable release | ||
| // channel is updated so that RFW can be compatible with it. | ||
| bool get isMainChannel { |
There was a problem hiding this comment.
Is the Flutter channel renaming actually happening soon? If not, this seems like confusing naming.
There was a problem hiding this comment.
master and main are synonyms now for flutter/flutter.
|
updated per comment, will autoland on green. Feel free to remove the |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/packages/4650, due to Pull request flutter/packages/4650 is not in a mergeable state. |
flutter/packages@c730a90...3060b1a 2023-08-23 [email protected] [rfw] Support web (as JS) (flutter/packages#4650) 2023-08-22 [email protected] [webview_flutter] Update sample code. (flutter/packages#4727) 2023-08-22 [email protected] [flutter_adaptive_scaffold] Fix top padding for NavigationBar (flutter/packages#4661) 2023-08-22 [email protected] Remove deprecated `ImageProvider` methods (flutter/packages#4725) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Pre-launch Checklist
Fixes flutter/flutter#129843
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).