Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker] getMedia platform implementations #4175

Merged
merged 10 commits into from
Jun 15, 2023

Conversation

tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Jun 9, 2023

Adds getMedia and getMultipleMedia methods to all image_picker platforms.

waiting on #4174

precursor to #3892

part of flutter/flutter#89159

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal tarrinneal requested a review from stuartmorgan June 12, 2023 18:59
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits; mostly I missed the examples not being updated.

@tarrinneal tarrinneal force-pushed the getMediaPlatformImplementation branch from a5ce9fd to 83f407a Compare June 12, 2023 22:26
@tarrinneal tarrinneal force-pushed the getMediaPlatformImplementation branch from 810e177 to dc2f9b8 Compare June 12, 2023 22:41
@tarrinneal tarrinneal requested a review from stuartmorgan June 12, 2023 23:52
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@tarrinneal
Copy link
Contributor Author

Merging manually since tree is green but frozen

@tarrinneal tarrinneal merged commit 7869896 into flutter:main Jun 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 16, 2023
flutter/packages@f9314a3...59d93d6

2023-06-16 [email protected] [tool] Add command aliases (flutter/packages#4207)
2023-06-16 [email protected] [google_map_flutter] Fix map object regression due to async changes (flutter/packages#4171)
2023-06-16 [email protected] [url_launcher] Add ignores for deprecated member to test (flutter/packages#4220)
2023-06-15 [email protected] Roll Flutter from 95be76a to b0188cd (10 revisions) (flutter/packages#4221)
2023-06-15 [email protected] [camera_android] Upgrading roboelectric from 4.5 to 4.10.3 (flutter/packages#4018)
2023-06-15 [email protected] [go_router] Fixes bug that GoRouterState in top level redirect doesn'â�¦ (flutter/packages#4173)
2023-06-15 [email protected] [go_router]Updates documentations around GoRouter.of, GoRouter.maybeOf, and BuildContext extension. (flutter/packages#4176)
2023-06-15 [email protected] [tool] Support code excerpts for any .md file (flutter/packages#4212)
2023-06-15 [email protected] [webview_flutter] Add support for limitsNavigationsToAppBoundDomains (flutter/packages#4026)
2023-06-15 [email protected] [webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions (flutter/packages#3795)
2023-06-15 [email protected] [image_picker] add getMedia method (flutter/packages#3892)
2023-06-15 [email protected] [image_picker] getMedia platform implementations (flutter/packages#4175)
2023-06-14 [email protected] Ignore `textScaleFactor` deprecation (flutter/packages#4209)
2023-06-14 [email protected] [pigeon] Enable Obj-C integration tests in CI (flutter/packages#4215)
2023-06-14 [email protected] [flutter_adaptive_scaffold] Support RTL (flutter/packages#4204)
2023-06-14 [email protected] Manual roll Flutter from 09b7e56 to 95be76a (14 revisions) (flutter/packages#4214)
2023-06-14 [email protected] Roll Flutter (stable) from 682aa38 to 796c8ef (5 revisions) (flutter/packages#4213)
2023-06-14 [email protected] Roll Flutter from 353b8bc to 09b7e56 (17 revisions) (flutter/packages#4206)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants