[image_picker] add getMedia method #3892

tarrinneal · 2023-05-03T01:39:32Z

Adds getMedia and getMultipleMedia methods to all platforms.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth

Should there be a single vs multi media picker option? Seems to me that currently it's set up for multiple with no way to limit it to a single image/video selection

packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m

vashworth · 2023-05-22T15:22:28Z

packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m

+ * Processes the video.
+ */
+- (void)processVideo API_AVAILABLE(ios(14)) {
+  NSString *typeIdentifier = self.result.itemProvider.registeredTypeIdentifiers.firstObject;


Are we confident the first type is always the one we want? Does using different types cause different outcomes? Like if the video was an MP4, I'd image it might have UTTypeAudiovisualContent, UTTypeMovie, UTTypeMPEG4Movie, etc. Does using UTTypeAudiovisualContent vs UTTypeMPEG4Movie make a difference?

The first type is just the type that was registered first. I think it should be fine as is, but if you know of some reason this may cause issues, it can be updated.

packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m

packages/image_picker/image_picker_ios/lib/image_picker_ios.dart

tarrinneal · 2023-05-22T18:29:58Z

Should there be a single vs multi media picker option? Seems to me that currently it's set up for multiple with no way to limit it to a single image/video selection

I actually had that written in initially and removed it since I didn't think it would make a lot of sense. I can add it back in if people disagree.

stuartmorgan · 2023-05-22T19:28:19Z

I actually had that written in initially and removed it since I didn't think it would make a lot of sense. I can add it back in if people disagree.

Plugin clients will definitely want the ability to limit to a single item. (Ideally we'd want to limit to N items, but we can't actually implement that on all platforms, which is why we don't have the API.)

The way we should handle it structurally is at the platform interface layer have a single method with a bool for multiple selection, and at the app-facing level have two methods (so that they don't have to extract from a list in the common case of only allowing one item).

stuartmorgan

I just did quick high-level feedback for now.

packages/image_picker/image_picker/README.md

packages/image_picker/image_picker/lib/image_picker.dart

...picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

...picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart

...ages/image_picker/image_picker_platform_interface/lib/src/types/media_selection_options.dart

packages/image_picker/image_picker/example/lib/main.dart

...picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

packages/image_picker/image_picker_platform_interface/lib/src/types/image_options.dart

...ages/image_picker/image_picker_platform_interface/lib/src/types/media_selection_options.dart

packages/image_picker/image_picker_windows/lib/image_picker_windows.dart

packages/image_picker/image_picker_windows/test/image_picker_windows_test.dart

packages/image_picker/image_picker_ios/ios/Classes/FLTImagePickerPhotoAssetUtil.m

packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart

...cker/image_picker_platform_interface/lib/src/method_channel/method_channel_image_picker.dart

packages/image_picker/image_picker_platform_interface/lib/src/types/media_options.dart

packages/image_picker/image_picker_ios/lib/image_picker_ios.dart

packages/image_picker/image_picker/lib/image_picker.dart

...picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

packages/image_picker/image_picker_android/lib/image_picker_android.dart

packages/image_picker/image_picker_android/pigeons/messages.dart

...cker/image_picker_platform_interface/lib/src/method_channel/method_channel_image_picker.dart

packages/image_picker/image_picker_windows/lib/image_picker_windows.dart

packages/image_picker/image_picker_windows/test/image_picker_windows_test.dart

packages/image_picker/image_picker/lib/image_picker.dart

...picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java

stuartmorgan

LGTM!

Adds `getMedia` and `getMultipleMedia` methods to image_picker_platform_interface. precursor to #3892 part of flutter/flutter#89159

hectorAguero · 2023-06-12T01:39:17Z

I actually had that written in initially and removed it since I didn't think it would make a lot of sense. I can add it back in if people disagree.

Plugin clients will definitely want the ability to limit to a single item. (Ideally we'd want to limit to N items, but we can't actually implement that on all platforms, which is why we don't have the API.)

The way we should handle it structurally is at the platform interface layer have a single method with a bool for multiple selection, and at the app-facing level have two methods (so that they don't have to extract from a list in the common case of only allowing one item).

Hey @stuartmorgan, not fully related to this PR, but what platforms doesn't support N item limit?

For what I know, In the past was Android, but know there is the new photopicker, also I saw you reopen this issue but the comments and likes are not enabled flutter/flutter#85772

stuartmorgan · 2023-06-12T02:47:33Z

what platforms doesn't support N item limit?

Almost all of them, as far as I know.

I saw you reopen this issue but the comments and likes are not enabled flutter/flutter#85772

That was an oversight; fixed

stuartmorgan

Still LGTM!

Adds `getMedia` and `getMultipleMedia` methods to all image_picker platforms. ~~waiting on #4174 precursor to #3892 part of flutter/flutter#89159 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates [following repository CHANGELOG style]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests

flutter/packages@f9314a3...59d93d6 2023-06-16 [email protected] [tool] Add command aliases (flutter/packages#4207) 2023-06-16 [email protected] [google_map_flutter] Fix map object regression due to async changes (flutter/packages#4171) 2023-06-16 [email protected] [url_launcher] Add ignores for deprecated member to test (flutter/packages#4220) 2023-06-15 [email protected] Roll Flutter from 95be76a to b0188cd (10 revisions) (flutter/packages#4221) 2023-06-15 [email protected] [camera_android] Upgrading roboelectric from 4.5 to 4.10.3 (flutter/packages#4018) 2023-06-15 [email protected] [go_router] Fixes bug that GoRouterState in top level redirect doesn'â�¦ (flutter/packages#4173) 2023-06-15 [email protected] [go_router]Updates documentations around GoRouter.of, GoRouter.maybeOf, and BuildContext extension. (flutter/packages#4176) 2023-06-15 [email protected] [tool] Support code excerpts for any .md file (flutter/packages#4212) 2023-06-15 [email protected] [webview_flutter] Add support for limitsNavigationsToAppBoundDomains (flutter/packages#4026) 2023-06-15 [email protected] [webview_flutter][webview_flutter_android] Add android support for handling geolocation permissions (flutter/packages#3795) 2023-06-15 [email protected] [image_picker] add getMedia method (flutter/packages#3892) 2023-06-15 [email protected] [image_picker] getMedia platform implementations (flutter/packages#4175) 2023-06-14 [email protected] Ignore `textScaleFactor` deprecation (flutter/packages#4209) 2023-06-14 [email protected] [pigeon] Enable Obj-C integration tests in CI (flutter/packages#4215) 2023-06-14 [email protected] [flutter_adaptive_scaffold] Support RTL (flutter/packages#4204) 2023-06-14 [email protected] Manual roll Flutter from 09b7e56 to 95be76a (14 revisions) (flutter/packages#4214) 2023-06-14 [email protected] Roll Flutter (stable) from 682aa38 to 796c8ef (5 revisions) (flutter/packages#4213) 2023-06-14 [email protected] Roll Flutter from 353b8bc to 09b7e56 (17 revisions) (flutter/packages#4206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Adds `getMedia` and `getMultipleMedia` methods to all image_picker platforms. ~~waiting on flutter/packages#4174 precursor to flutter/packages#3892 part of flutter/flutter#89159 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates [following repository CHANGELOG style]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests

github-actions bot added p: image_picker platform-android platform-ios platform-web platform-windows labels May 3, 2023

tarrinneal force-pushed the image+video branch from 0547f57 to 7b502fd Compare May 19, 2023 20:24

tarrinneal requested a review from stuartmorgan May 19, 2023 20:37

tarrinneal marked this pull request as ready for review May 19, 2023 20:37

tarrinneal requested review from cbracken, vashworth, gmackall and ditman as code owners May 19, 2023 20:37

vashworth reviewed May 22, 2023

View reviewed changes

stuartmorgan requested changes May 22, 2023

View reviewed changes

tarrinneal force-pushed the image+video branch from 06a99b3 to 3743257 Compare May 23, 2023 01:07

tarrinneal requested review from stuartmorgan and vashworth May 23, 2023 19:49

stuartmorgan requested changes May 24, 2023

View reviewed changes

chrisbobbe mentioned this pull request May 25, 2023

compose: Give better media-picker UI on Android zulip/zulip-flutter#114

Closed

tarrinneal requested a review from stuartmorgan May 26, 2023 22:12

tarrinneal commented May 27, 2023

View reviewed changes

packages/image_picker/image_picker_ios/ios/Classes/FLTImagePickerPhotoAssetUtil.m Outdated Show resolved Hide resolved

ditman reviewed May 27, 2023

View reviewed changes

packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart Outdated Show resolved Hide resolved

stuartmorgan requested changes May 30, 2023

View reviewed changes

tarrinneal requested a review from stuartmorgan June 5, 2023 16:38

stuartmorgan requested changes Jun 7, 2023

View reviewed changes

tarrinneal requested a review from stuartmorgan June 8, 2023 02:18

stuartmorgan approved these changes Jun 9, 2023

View reviewed changes

tarrinneal mentioned this pull request Jun 9, 2023

[image_picker] getMedia platform changes #4174

Merged

11 tasks

tarrinneal force-pushed the image+video branch from 4a43c6b to 3f4a389 Compare June 9, 2023 22:31

github-actions bot removed platform-android platform-ios platform-windows platform-web labels Jun 9, 2023

auto-submit bot pushed a commit that referenced this pull request Jun 9, 2023

[image_picker] getMedia platform changes (#4174)

6565f17

Adds `getMedia` and `getMultipleMedia` methods to image_picker_platform_interface. precursor to #3892 part of flutter/flutter#89159

Merge branch 'main' of github.com:flutter/packages into image+video

1494ddd

tarrinneal removed request for cbracken, vashworth and gmackall June 10, 2023 02:01

stuartmorgan approved these changes Jun 14, 2023

View reviewed changes

tarrinneal added 3 commits June 14, 2023 17:39

Merge branch 'main' of github.com:flutter/packages into image+video

1bf6509

Merge branch 'main' of github.com:flutter/packages into image+video

cfb7b8d

order

db79d69

tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 15, 2023

auto-submit bot merged commit c0cba0b into flutter:main Jun 15, 2023

engine-flutter-autoroll mentioned this pull request Jun 16, 2023

Roll Packages from f9314a3b833a to 59d93d64cb83 (18 revisions) flutter/flutter#129014

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023

c0cba0b [image_picker] add getMedia method (flutter/packages#3892)

e886b53

engine-flutter-autoroll mentioned this pull request Jun 16, 2023

Roll Packages from f9314a3b833a to 59d93d64cb83 (18 revisions) flutter/flutter#129021

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 16, 2023

c0cba0b [image_picker] add getMedia method (flutter/packages#3892)

60997d4

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] add getMedia method #3892

[image_picker] add getMedia method #3892

tarrinneal commented May 3, 2023 •

edited

Loading

vashworth left a comment

vashworth May 22, 2023

tarrinneal May 23, 2023

tarrinneal commented May 22, 2023

stuartmorgan commented May 22, 2023

stuartmorgan left a comment

stuartmorgan left a comment

hectorAguero commented Jun 12, 2023

stuartmorgan commented Jun 12, 2023

stuartmorgan left a comment

[image_picker] add getMedia method #3892

[image_picker] add getMedia method #3892

Conversation

tarrinneal commented May 3, 2023 • edited Loading

Pre-launch Checklist

vashworth left a comment

Choose a reason for hiding this comment

vashworth May 22, 2023

Choose a reason for hiding this comment

tarrinneal May 23, 2023

Choose a reason for hiding this comment

tarrinneal commented May 22, 2023

stuartmorgan commented May 22, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment

hectorAguero commented Jun 12, 2023

stuartmorgan commented Jun 12, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

tarrinneal commented May 3, 2023 •

edited

Loading