Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Manual flutter roll #4033

Merged
merged 4 commits into from
May 18, 2023
Merged

[ci] Manual flutter roll #4033

merged 4 commits into from
May 18, 2023

Conversation

ditman
Copy link
Member

@ditman ditman commented May 17, 2023 •
edited
Loading

Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:

  • [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
  • [google_sign_in] dart format .
  • [webview_flutter] dart format .

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from domesticmouse as a code owner May 17, 2023 21:40
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@ditman ditman force-pushed the manual-flutter-roll branch from 24c1745 to 4075ac4 Compare May 17, 2023 21:42
@ditman ditman requested a review from bparrishMines as a code owner May 17, 2023 22:44
@ditman
Copy link
Member Author

ditman commented May 17, 2023 

  google_sign_in_web:
    Missing version change
  webview_flutter_android:
    Missing version change
  webview_flutter_web:
    Missing version change

The changes in those packages are only dart format .; do we need to release those?

@ditman ditman added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels May 17, 2023
@ditman
Copy link
Member Author

ditman commented May 17, 2023

(Overridden version/changelog after talking to @stuartmorgan on discord.)

@ditman ditman requested a review from stuartmorgan May 17, 2023 23:03
@ditman
Copy link
Member Author

ditman commented May 17, 2023 •
edited
Loading

This PR actually allows tests to run in newer versions of Flutter.

stuartmorgan
stuartmorgan approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label May 18, 2023
@auto-submit auto-submit bot merged commit 3b377bd into flutter:main May 18, 2023
@ditman ditman deleted the manual-flutter-roll branch May 18, 2023 00:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2023
@engine-flutter-autoroll
3b377bd [ci] Manual flutter roll (flutter/packages#4033)
7d9a803
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 18, 2023
@engine-flutter-autoroll
Roll Packages from 5c69914 to b31a128 (9 revisions) (#127109)
5381e82 
flutter/packages@5c69914...b31a128

2023-05-18 [email protected] [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 [email protected] [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 [email protected] [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 [email protected] [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 [email protected] [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 [email protected] Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 [email protected] [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 [email protected] [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@engine-flutter-autoroll
Roll Packages from 5c69914 to b31a128 (9 revisions) (flutter#127109)
abf1bad 
flutter/packages@5c69914...b31a128

2023-05-18 [email protected] [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030)
2023-05-18 [email protected] [rfw] Fix a typo in the API documentation (flutter/packages#4023)
2023-05-18 [email protected] [ci] Manual flutter roll (flutter/packages#4033)
2023-05-17 [email protected] [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746)
2023-05-17 [email protected] [tools] Ignore comments in federated safety check (flutter/packages#4028)
2023-05-17 [email protected] Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027)
2023-05-17 [email protected] [camera] Fix Java lints in camerax version (flutter/packages#3966)
2023-05-17 [email protected] [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968)
2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@ditman @nploi
[ci] Manual flutter roll (flutter#4033)
d4992ce 
Attempt to manually roll flutter (stable and master), fixing what's preventing the auto-rolls:

* [flutter_markdown] Teach a mock AssetManager of the new .smcbin asset file format.
* [google_sign_in] dart format .
* [webview_flutter] dart format .
@reidbaker reidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@ditman ditman mentioned this pull request Aug 1, 2023
Merged
8 tasks
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@domesticmouse domesticmouse Awaiting requested review from domesticmouse domesticmouse is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: flutter_markdown p: google_sign_in p: webview_flutter platform-android platform-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditman @stuartmorgan