[flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar #3746

fmt-Println-MKO · 2023-04-17T18:21:04Z

To have a common Material 3 Design, BottomNavigationBar was replaced with M3 NavigationBar as adaptive scaffold claims to be Material 3.

fixes: #124984

Pre-launch Checklist

use Material 3 NavigationBar instead of BottomNavigationBar from M2

google-cla · 2023-04-17T18:21:09Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

packages/flutter_adaptive_scaffold/pubspec.yaml

packages/flutter_adaptive_scaffold/CHANGELOG.md

packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart

gspencergoog

justinmc

LGTM with a formatting nit. Thanks!

packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart

justinmc

LGTM with a formatting nit. Thanks!

Co-authored-by: Justin McCandless <[email protected]>

fmt-Println-MKO · 2023-05-16T20:48:23Z

LGTM with a formatting nit. Thanks!

now it failed with wrong formatting :(

fmt-Println-MKO · 2023-05-17T10:14:55Z

@justinmc any suggestion on how to solve the formatting issue?
either roll back to the version that worked in the pipeline or any other idea?

gspencergoog · 2023-05-17T16:40:14Z

Just go back to the version that passes. Formatting is enforced in flutter/packages, so there's really only one way to format it that works (what dartfmt says).

fmt-Println-MKO · 2023-05-17T22:14:04Z

ok formatting is fixed, it's ready for merge :)

… NavigationBar (flutter/packages#3746)

flutter/packages@5c69914...b31a128 2023-05-18 [email protected] [flutter_plugin_android_lifecycle] Fix lints (flutter/packages#4030) 2023-05-18 [email protected] [rfw] Fix a typo in the API documentation (flutter/packages#4023) 2023-05-18 [email protected] [ci] Manual flutter roll (flutter/packages#4033) 2023-05-17 [email protected] [flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar (flutter/packages#3746) 2023-05-17 [email protected] [tools] Ignore comments in federated safety check (flutter/packages#4028) 2023-05-17 [email protected] Revert "[url_launcher] Set broadcast reciever visability as required by target api 34" (flutter/packages#4027) 2023-05-17 [email protected] [camera] Fix Java lints in camerax version (flutter/packages#3966) 2023-05-17 [email protected] [image_picker] Upgrade androidx.activity to 1.7.0 and add a dependency on kotlin-bom to align kotlin transitive dependencies (flutter/packages#3968) 2023-05-17 49699333+dependabot[bot]@users.noreply.github.com [espresso]: Bump com.squareup.okhttp3:okhttp from 4.10.0 to 4.11.0 in /packages/espresso/android (flutter/packages#3804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ionBar (flutter#3746) To have a common Material 3 Design, BottomNavigationBar was replaced with M3 NavigationBar as adaptive scaffold claims to be Material 3. [fixes: #124984](flutter/flutter#124984) * [x] I read the [Contributor Guide](https://github.com/flutter/packages/blob/main/CONTRIBUTING.md) and followed the process outlined there for submitting PRs. * [x] I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities. * [x] I read and followed the [relevant style guides](https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style) and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) * [x] I signed the [CLA](https://cla.developers.google.com/). * [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` * [x] I listed at least one issue that this PR fixes in the description above. * [x] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy](https://dart.dev/tools/pub/versioning), or this PR is [exempt from version changes](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates). * [x] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style). * [x] I updated/added relevant documentation (doc comments with `///`). * [x] I added new tests to check the change I am making, or this PR is [test-exempt](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests). * [x] All existing and new tests are passing.

fmt-Println-MKO and others added 3 commits April 17, 2023 19:49

replaced BottomNavigationBar with NavigationBar

d186e34

use Material 3 NavigationBar instead of BottomNavigationBar from M2

fixed test to pass new NavigationBar design

8d95eb6

updated version to 0.1.4

29020c0

fmt-Println-MKO requested a review from gspencergoog as a code owner April 17, 2023 18:21

github-actions bot added the p: flutter_adaptive_scaffold label Apr 17, 2023

fmt-Println-MKO and others added 6 commits April 17, 2023 20:26

fixed formating

1fe63ce

fixed example test

8be3ea6

fixed formatting in example unit test

f7f8d3f

fixed formatting in example unit test

7584b58

Merge branch 'main' into main

7891c11

Merge branch 'main' into main

90efd53

gspencergoog reviewed Apr 27, 2023

View reviewed changes

packages/flutter_adaptive_scaffold/pubspec.yaml Outdated Show resolved Hide resolved

packages/flutter_adaptive_scaffold/CHANGELOG.md Outdated Show resolved Hide resolved

packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart Show resolved Hide resolved

fmt-Println-MKO and others added 4 commits May 6, 2023 14:00

Merge branch 'main' into main

8f72413

fixed new line at end of file

9249a60

fixed, use iconSize property for NavigationBar

385690d

fixed formating

8d69ac3

gspencergoog reviewed May 8, 2023

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart Outdated Show resolved Hide resolved

fmt-Println-MKO and others added 6 commits May 9, 2023 20:23

Merge branch 'main' into main

19e37bd

fixed NavBarThemeData as base for new iconSize

d7245c8

fixed, added BuildContext type

591ce3f

Merge branch 'main' into main

456c326

Merge branch 'main' into main

876363f

Merge branch 'main' into main

e28664b

stuartmorgan requested a review from gspencergoog May 16, 2023 20:07

gspencergoog approved these changes May 16, 2023

View reviewed changes

justinmc approved these changes May 16, 2023

View reviewed changes

packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart Outdated Show resolved Hide resolved

justinmc approved these changes May 16, 2023

View reviewed changes

fmt-Println-MKO and others added 2 commits May 16, 2023 22:25

Update packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart

35a1361

Co-authored-by: Justin McCandless <[email protected]>

Merge branch 'main' into main

3099c95

Merge branch 'main' into main

bc45bd2

fmt-Println-MKO and others added 3 commits May 17, 2023 21:12

fixed formatting

d404401

Merge branch 'main' into main

5174e24

Merge branch 'main' into main

747ae4e

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 17, 2023

auto-submit bot merged commit 9e52ec4 into flutter:main May 17, 2023

engine-flutter-autoroll mentioned this pull request May 18, 2023

Roll Packages from 5c6991400e91 to b31a12861905 (9 revisions) flutter/flutter#127109

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2023

9e52ec4 [flutter_adaptive_scaffold] exchange BottomNavigationBar with…

74f7236

… NavigationBar (flutter/packages#3746)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar #3746

[flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar #3746

fmt-Println-MKO commented Apr 17, 2023 •

edited

Loading

google-cla bot commented Apr 17, 2023

gspencergoog left a comment

justinmc left a comment

justinmc left a comment

fmt-Println-MKO commented May 16, 2023

fmt-Println-MKO commented May 17, 2023

gspencergoog commented May 17, 2023

fmt-Println-MKO commented May 17, 2023

[flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar #3746

[flutter_adaptive_scaffold] exchange BottomNavigationBar with NavigationBar #3746

Conversation

fmt-Println-MKO commented Apr 17, 2023 • edited Loading

Pre-launch Checklist

google-cla bot commented Apr 17, 2023

gspencergoog left a comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

fmt-Println-MKO commented May 16, 2023

fmt-Println-MKO commented May 17, 2023

gspencergoog commented May 17, 2023

fmt-Println-MKO commented May 17, 2023

fmt-Println-MKO commented Apr 17, 2023 •

edited

Loading