[webview_flutter_android] Added the functionality to fullscreen html5 video #3879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulppn
force-pushed
the
feature/add_fullscreen_video
branch
from
cd5a5d0 to
279a678
Compare
|
Update from triage: waiting for @bparrishMines to have review bandwidth. |
...roid/android/src/main/java/io/flutter/plugins/webviewflutter/WebChromeClientHostApiImpl.java
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@mvanbeusekom Who should be looped in on this PR now? |
I will pick it up, I am still in contact with @paulppn and will double check with him to transfer knowledge. |
…ration_test/webview_flutter_test.dart
stuartmorgan
approved these changes
Aug 24, 2023
| @@ -36,7 +36,7 @@ This can be configured for versions >=23 with | |||
| `AndroidWebViewWidgetCreationParams.displayWithHybridComposition`. See https://pub.dev/packages/webview_flutter#platform-specific-features | |||
| for more details on setting platform-specific features in the main plugin. | |||
|
|
|||
| ### External Native API | |||
| ## External Native API | |||
There was a problem hiding this comment.
Wasn't this correct before? This section seems to be Android-only as written.
|
One minor question about the README, but @bparrishMines please land this whenever you are happy with it. |
|
So before this change, the fullscreen button does nothing and doesn't interrupt the video. something.webmAfter this change, the screen will flicker and pause the video if the device-2023-08-25-150840.webmThis seems to be caused by the fact that the Java |
2 tasks
stuartmorgan
approved these changes
Sep 7, 2023
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 11, 2023
flutter/packages@aaae5ef...ef0c65e 2023-09-11 [email protected] Roll Flutter from 7c28e8e to 219efce (16 revisions) (flutter/packages#4901) 2023-09-11 [email protected] [url_launcher] migrating iOS tests from objc to swift (flutter/packages#4758) 2023-09-09 [email protected] Roll Flutter from da676f7 to 7c28e8e (20 revisions) (flutter/packages#4879) 2023-09-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/packages#4863) 2023-09-08 [email protected] Roll Flutter from aea4552 to da676f7 (28 revisions) (flutter/packages#4874) 2023-09-08 [email protected] [webview_flutter_android] Added the functionality to fullscreen html5 video (flutter/packages#3879) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorgalo
pushed a commit
to victorgalo/flutter
that referenced
this pull request
Sep 11, 2023
flutter/packages@aaae5ef...ef0c65e 2023-09-11 [email protected] Roll Flutter from 7c28e8e to 219efce (16 revisions) (flutter/packages#4901) 2023-09-11 [email protected] [url_launcher] migrating iOS tests from objc to swift (flutter/packages#4758) 2023-09-09 [email protected] Roll Flutter from da676f7 to 7c28e8e (20 revisions) (flutter/packages#4879) 2023-09-09 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter/packages#4863) 2023-09-08 [email protected] Roll Flutter from aea4552 to da676f7 (28 revisions) (flutter/packages#4874) 2023-09-08 [email protected] [webview_flutter_android] Added the functionality to fullscreen html5 video (flutter/packages#3879) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
sybrands-place
pushed a commit
to sybrands-place/packages
that referenced
this pull request
Sep 14, 2023
* main: (83 commits) go_router_builder: support the latest pkg:analyzer (flutter#4921) Replace collection type lints with more general lint (flutter#4912) Roll Flutter from 219efce to 4e7a07a (30 revisions) (flutter#4910) [camerax] Implement `startVideoCapturing` and `onVideoRecordedEvent` (flutter#4815) [tool] Add a package inclusion filter (flutter#4904) [flutter_markdown] Fix changelog regarding minimum supported SDK version (flutter#4851) [ios_platform_images] Add integration tests (flutter#4899) [image_picker] Copy exif tags in categories II and III (flutter#4738) [google_maps_flutter_android] Fix for testToggleInfoWindow persistently flaky (flutter#4768) Roll Flutter from 7c28e8e to 219efce (16 revisions) (flutter#4901) [url_launcher] migrating iOS tests from objc to swift (flutter#4758) Roll Flutter from da676f7 to 7c28e8e (20 revisions) (flutter#4879) Bump actions/upload-artifact from 3.1.2 to 3.1.3 (flutter#4863) Roll Flutter from aea4552 to da676f7 (28 revisions) (flutter#4874) [webview_flutter_android] Added the functionality to fullscreen html5 video (flutter#3879) [tool] Add Android dependency (gradle) option to update dependencies command (flutter#4757) [camerax] Implement resolution configuration (flutter#3799) Manual roll Flutter from 685ce14 to aea4552 (64 revisions) (flutter#4870) [rfw, ci] Regenerate goldens, manually roll flutter#4835 (flutter#4862) Bump actions/checkout from 3.6.0 to 4.0.0 (flutter#4845) ...
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment on android the fullscreen html5 video does not work. This PR solves that issues, adding the functionality that the video is played fullscreen when you click on the fullscreen-button in the video player.
Fixes flutter/flutter#27101
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.