[camera] CameraPlatform.createCameraWithSettings

packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart

@@ -51,14 +51,9 @@ abstract class CameraPlatform extends PlatformInterface {
     CameraDescription cameraDescription,
     ResolutionPreset? resolutionPreset, {
     bool enableAudio = false,
-  }) =>
-      createCameraWithSettings(
-        cameraDescription,
-        MediaSettings(
-          resolutionPreset: resolutionPreset,
-          enableAudio: enableAudio,
-        ),
-      );
+  }) {
+    throw UnimplementedError('createCamera() is not implemented.');
+  }
 
   /// Creates an uninitialized camera instance and returns the cameraId.
   ///
@@ -67,7 +62,7 @@ abstract class CameraPlatform extends PlatformInterface {
     CameraDescription cameraDescription,
     MediaSettings mediaSettings,
   ) {
-    throw UnimplementedError('createCameraWithSettings() is not implemented.');
+    return createCamera(cameraDescription, mediaSettings.resolutionPreset);
   }
 
   /// Initializes the camera on the device.

packages/camera/camera_platform_interface/lib/src/types/media_settings.dart

@@ -10,7 +10,7 @@ import 'resolution_preset.dart';
 ///
 /// Used in [CameraPlatform.createCameraWithSettings].
 /// Allows to tune recorded video parameters, such as resolution, frame rate, bitrate.
-/// If [fps], [videoBitrate] and [audioBitrate] passed, they must be greater than zero.
+/// If [fps], [videoBitrate] or [audioBitrate] are passed, they must be greater than zero.
 class MediaSettings {
   /// Creates a [MediaSettings].
   const MediaSettings({
@@ -29,18 +29,12 @@ class MediaSettings {
   final ResolutionPreset? resolutionPreset;
 
   /// Rate at which frames should be captured by the camera in frames per second.
-  ///
-  /// Must be null or greater than zero
   final int? fps;
 
   /// The video encoding bit rate for recording.
-  ///
-  /// Must be null or greater than zero
   final int? videoBitrate;
 
   /// The audio encoding bit rate for recording.
-  ///
-  /// Must be null or greater than zero
   final int? audioBitrate;
 
   /// Controls audio presence in recorded video.

packages/camera/camera_platform_interface/test/types/media_settings_test.dart

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// ignore_for_file: always_specify_types
+
 import 'package:camera_platform_interface/camera_platform_interface.dart';
 import 'package:flutter_test/flutter_test.dart';
 
@@ -101,42 +103,108 @@ void main() {
     );
   });
 
-  test('MediaSettings hash should be Object.hash of passed parameters', () {
-    const MediaSettings settings1 = MediaSettings(
-      resolutionPreset: ResolutionPreset.low,
-      fps: 20,
-      videoBitrate: 128000,
-      audioBitrate: 32000,
-      enableAudio: true,
-    );
+  group('MediaSettings == operator', () {
+    const ResolutionPreset preset1 = ResolutionPreset.low;
+    const int fps1 = 20;
+    const int videoBitrate1 = 128000;
+    const int audioBitrate1 = 32000;
+    const bool enableAudio1 = true;
 
-    const MediaSettings settings1Copy = MediaSettings(
+    const ResolutionPreset preset2 = ResolutionPreset.high;
+    const int fps2 = fps1 + 10;
+    const int videoBitrate2 = videoBitrate1 * 2;
+    const int audioBitrate2 = audioBitrate1 * 2;
+    const bool enableAudio2 = !enableAudio1;
+
+    const MediaSettings settings1 = MediaSettings(
       resolutionPreset: ResolutionPreset.low,
       fps: 20,
       videoBitrate: 128000,
       audioBitrate: 32000,
       enableAudio: true,
     );
 
-    const MediaSettings settings2 = MediaSettings(
-      resolutionPreset: ResolutionPreset.high,
-      fps: 30,
-      videoBitrate: 256000,
-      audioBitrate: 64000,
-    );
-
-    expect(
-      settings1 == settings1Copy,
-      isTrue,
-      reason:
-          'MediaSettings == operator should return true for equal parameters',
-    );
-
-    expect(
-      settings1 == settings2,
-      isFalse,
-      reason:
-          'MediaSettings == operator should return false for non-equal parameters',
-    );
+    // test operator== on parameters combination.
+    void checkParameters(List<dynamic> args) {
+      final resolutionPreset = args[0] as ResolutionPreset?;
+      final fps = args[1] as int?;
+      final videoBitrate = args[2] as int?;
+      final audioBitrate = args[3] as int?;
+      final enableAudio = args[4]! as bool;
+
+      final MediaSettings settings2 = MediaSettings(
+          resolutionPreset: resolutionPreset,
+          fps: fps,
+          videoBitrate: videoBitrate,
+          audioBitrate: audioBitrate,
+          enableAudio: enableAudio);
+
+      if (resolutionPreset == preset1 &&
+          fps == fps1 &&
+          videoBitrate == videoBitrate1 &&
+          audioBitrate == audioBitrate1 &&
+          enableAudio == enableAudio1) {
+        expect(
+          settings1 == settings2,
+          isTrue,
+          reason:
+              'MediaSettings == operator should return true for equal parameters: $settings1 == $settings2',
+        );
+      } else {
+        expect(
+          settings1 == settings2,
+          isFalse,
+          reason:
+              'MediaSettings == operator should return false for non-equal parameters: $settings1 != $settings2',
+        );
+      }
+    }
+
+    test(
+        'MediaSettings == operator should be short-circuit AND of all parameters',
+        () {
+      // Sets of various parameters, including those equal and not equal to the corresponding `settings1` parameters
+      final params = [
+        {preset1, preset2, null},
+        {fps1, fps2, null},
+        {videoBitrate1, videoBitrate2, null},
+        {audioBitrate1, audioBitrate2, null},
+        {enableAudio1, enableAudio2},
+      ];
+
+      // recursively check all possible parameters combinations
+      void combine(List<Set<dynamic>> params, List<dynamic> args, int level) {
+        if (params.length == level) {
+          // now args contains all required parameters, so check `operator ==` now
+          checkParameters(args);
+        } else {
+          for (final variant in params[level]) {
+            combine(params, [...args, variant], level + 1);
+          }
+        }
+      }
+
+      combine(params, [], 0);
+    });
+
+    test('Identical objects should be equal', () {
+      const MediaSettings settingsIdentical = settings1;
+
+      expect(
+        settings1 == settingsIdentical,
+        isTrue,
+        reason:
+            'MediaSettings == operator should return true for identical objects',
+      );
+    });
+
+    test('Objects of different types should be non-equal', () {
+      expect(
+        settings1 == Object(),
+        isFalse,
+        reason:
+            'MediaSettings == operator should return false for objects of different types',
+      );
+    });
   });
 }