[camera] CameraPlatform.createCameraWithSettings

[PROGrand]

Platform interface of federated plugin

This is the platform-interface part of camera PR #3586.

App-facing change

Previously, CameraController was unable to setup fps and bitrates, allowing only resolution settings like this:

controller = CameraController(_cameras[0], ResolutionPreset.max);

This PR gives additional functionality to set fps and bitrates via withSettings:

controller = CameraController.withSettings(
      _cameras[0],
      mediaSettings: const MediaSettings(
        resolutionPreset: ResolutionPreset.low,
        fps: 15,
        videoBitrate: 200000,
        audioBitrate: 32000,
        enableAudio: true,
      ),
    );

Android, iOS, etc.

All platforms must implement CameraPlatform.createCameraWithSettings in addition to CameraPlatform.createCamera, providing platform specific code for fps and `bitrate' platform:

Future<int> createCamera(
    CameraDescription cameraDescription,
    CameraDescription cameraDescription,
    ResolutionPreset? resolutionPreset, {
    ResolutionPreset? resolutionPreset, {
    bool enableAudio = false,
    bool enableAudio = false,
  }) {
  }) =>
    throw UnimplementedError('createCamera() is not implemented.');
      createCameraWithSettings(
        cameraDescription,
        MediaSettings(
          resolutionPreset: resolutionPreset,
          enableAudio: enableAudio,
        ),
      );

  /// Creates an uninitialized camera instance and returns the cameraId.
  Future<int> createCameraWithSettings(
    CameraDescription cameraDescription,
    MediaSettings? mediaSettings,
  ) {
    throw UnimplementedError('createCameraWithSettings() is not implemented.');
  }
  }

[bparrishMines]

This looks like a change that needs to follow https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins. This PR doesn't indicate how Android, iOS, and the app-facing package will use this new feature.

[PROGrand]

@bparrishMines

Updated PR description.

This is second PR (according to https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins).

First PR is here: #3586.

Can you please review #3586 ?

[xjosk]

hello, how is it going with this feature? i'd like to add it to my current app, i'm looking forward to it

[stuartmorgan]

Update from triage: this is waiting for the sub-PR referenced above to complete the review process.

[stuartmorgan]

@PROGrand The sub-issue was closed due to lack of updates. Have you decided not to move forward with this?

[stuartmorgan]

Update from triage: the sub-PR has been re-opened, so this is once again waiting on that to complete the review process.

[stuartmorgan]

It looks like I had the ordering inverted in my comments above; this is the sub-PR, and we were waiting for the combo PR to pass review. That seems to be done; @bparrishMines it looks like this is ready for your review.

[stuartmorgan]

@PROGrand Are you still planning on updating this so that it's ready for another review?

[PROGrand]

@stuartmorgan

@PROGrand Are you still planning on updating this so that it's ready for another review?

Yes, i can update this branch. But should main PR be reviewed first?

[bparrishMines]

LGTM with a couple nits

@stuartmorgan / @camsim99 for secondary review

[stuartmorgan]

LGTM, thanks!

[PROGrand]

how to use this pr in my camera

You should wait for #3586, or import camera from https://github.com/mtbo-org/packages