Copy part files and sourcemaps when building with dart2js. #146356

eyebrowsoffire · 2024-04-05T18:35:01Z

This fixes #145653

When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.

yjbanov · 2024-04-05T19:34:58Z

packages/flutter_tools/lib/src/build_system/targets/web.dart

+        if (file.basename == 'main.dart.js.map') {
+          return compilerConfig.sourceMaps;
+        }
+        final RegExp partFileRegex = RegExp(r'main\.dart\.js_[0-9].*\.part\.js');


Is there a risk of a silent failure if dart2js changes the file structure but we forget to update these regexes? Is there a way to fail hard during a Dart SDK roll?

I think that would require some larger end-to-end integration test. I'm going to file an issue as a follow-on for adding an integration test for this.

yjbanov

…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.

…lutter/flutter#146356)

flutter/flutter@477ebd8...98d23f7 2024-04-06 [email protected] Prepare for RenderDecorator.computeBaseline changes. (flutter/flutter#146363) 2024-04-06 [email protected] Roll Flutter Engine from 563bdb1d7976 to 605b3f35fa0a (1 revision) (flutter/flutter#146393) 2024-04-06 [email protected] Roll Flutter Engine from 482172d16528 to 563bdb1d7976 (1 revision) (flutter/flutter#146385) 2024-04-06 [email protected] Roll Flutter Engine from b0d7ac5425e9 to 482172d16528 (1 revision) (flutter/flutter#146382) 2024-04-06 [email protected] Roll Flutter Engine from df9f7433fc70 to b0d7ac5425e9 (2 revisions) (flutter/flutter#146377) 2024-04-06 [email protected] Roll Flutter Engine from b5039157cbc1 to df9f7433fc70 (1 revision) (flutter/flutter#146373) 2024-04-05 [email protected] Make FileSystem dependency explicit througout. (flutter/flutter#146008) 2024-04-05 [email protected] Roll Flutter Engine from 48604dfd9d49 to b5039157cbc1 (3 revisions) (flutter/flutter#146370) 2024-04-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/flutter#146368) 2024-04-05 [email protected] Roll Flutter Engine from da995a1061c5 to 48604dfd9d49 (2 revisions) (flutter/flutter#146366) 2024-04-05 [email protected] Roll Flutter Engine from 6a478d6931b2 to da995a1061c5 (1 revision) (flutter/flutter#146364) 2024-04-05 [email protected] Roll Flutter Engine from 62df3bd5f681 to 6a478d6931b2 (3 revisions) (flutter/flutter#146360) 2024-04-05 [email protected] Copy part files and sourcemaps when building with dart2js. (flutter/flutter#146356) 2024-04-05 [email protected] Roll Flutter Engine from d048b9aed529 to 62df3bd5f681 (1 revision) (flutter/flutter#146357) 2024-04-05 [email protected] Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (flutter/flutter#146307) 2024-04-05 [email protected] Roll Flutter Engine from 6974dbac35a1 to d048b9aed529 (1 revision) (flutter/flutter#146355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.

flutter/flutter@477ebd8...98d23f7 2024-04-06 [email protected] Prepare for RenderDecorator.computeBaseline changes. (flutter/flutter#146363) 2024-04-06 [email protected] Roll Flutter Engine from 563bdb1d7976 to 605b3f35fa0a (1 revision) (flutter/flutter#146393) 2024-04-06 [email protected] Roll Flutter Engine from 482172d16528 to 563bdb1d7976 (1 revision) (flutter/flutter#146385) 2024-04-06 [email protected] Roll Flutter Engine from b0d7ac5425e9 to 482172d16528 (1 revision) (flutter/flutter#146382) 2024-04-06 [email protected] Roll Flutter Engine from df9f7433fc70 to b0d7ac5425e9 (2 revisions) (flutter/flutter#146377) 2024-04-06 [email protected] Roll Flutter Engine from b5039157cbc1 to df9f7433fc70 (1 revision) (flutter/flutter#146373) 2024-04-05 [email protected] Make FileSystem dependency explicit througout. (flutter/flutter#146008) 2024-04-05 [email protected] Roll Flutter Engine from 48604dfd9d49 to b5039157cbc1 (3 revisions) (flutter/flutter#146370) 2024-04-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.9 to 3.24.10 (flutter/flutter#146368) 2024-04-05 [email protected] Roll Flutter Engine from da995a1061c5 to 48604dfd9d49 (2 revisions) (flutter/flutter#146366) 2024-04-05 [email protected] Roll Flutter Engine from 6a478d6931b2 to da995a1061c5 (1 revision) (flutter/flutter#146364) 2024-04-05 [email protected] Roll Flutter Engine from 62df3bd5f681 to 6a478d6931b2 (3 revisions) (flutter/flutter#146360) 2024-04-05 [email protected] Copy part files and sourcemaps when building with dart2js. (flutter/flutter#146356) 2024-04-05 [email protected] Roll Flutter Engine from d048b9aed529 to 62df3bd5f681 (1 revision) (flutter/flutter#146357) 2024-04-05 [email protected] Reland "Bump to AGP 8.1/Gradle 8.3 (almost) everywhere" (flutter/flutter#146307) 2024-04-05 [email protected] Roll Flutter Engine from 6974dbac35a1 to d048b9aed529 (1 revision) (flutter/flutter#146355) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Copy part files and sourcemaps when building with dart2js.

804bc8f

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 5, 2024

yjbanov reviewed Apr 5, 2024

View reviewed changes

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2024

yjbanov approved these changes Apr 5, 2024

View reviewed changes

auto-submit bot merged commit 75ae44d into flutter:master Apr 5, 2024
123 checks passed

eyebrowsoffire added the cp: beta cherry pick this pull request to beta release candidate branch label Apr 5, 2024

engine-flutter-autoroll mentioned this pull request Apr 6, 2024

Roll Flutter from 477ebd831c12 to 7971b3594b13 (14 revisions) flutter/packages#6475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2024

75ae44d Copy part files and sourcemaps when building with dart2js. (f…

432eae9

…lutter/flutter#146356)

engine-flutter-autoroll mentioned this pull request Apr 6, 2024

Roll Flutter from 477ebd831c12 to 7971b3594b13 (14 revisions) flutter/packages#6476

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2024

75ae44d Copy part files and sourcemaps when building with dart2js. (f…

aa74cfb

…lutter/flutter#146356)

engine-flutter-autoroll mentioned this pull request Apr 7, 2024

Roll Flutter from 477ebd831c12 to 98d23f709fec (16 revisions) flutter/packages#6477

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2024

75ae44d Copy part files and sourcemaps when building with dart2js. (f…

3021985

…lutter/flutter#146356)

engine-flutter-autoroll mentioned this pull request Apr 7, 2024

Roll Flutter from 477ebd831c12 to 98d23f709fec (16 revisions) flutter/packages#6478

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2024

75ae44d Copy part files and sourcemaps when building with dart2js. (f…

2c9c355

…lutter/flutter#146356)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy part files and sourcemaps when building with dart2js. #146356

Copy part files and sourcemaps when building with dart2js. #146356

eyebrowsoffire commented Apr 5, 2024

yjbanov Apr 5, 2024

eyebrowsoffire Apr 5, 2024

eyebrowsoffire Apr 5, 2024

yjbanov left a comment

Copy part files and sourcemaps when building with dart2js. #146356

Copy part files and sourcemaps when building with dart2js. #146356

Conversation

eyebrowsoffire commented Apr 5, 2024

yjbanov Apr 5, 2024

Choose a reason for hiding this comment

eyebrowsoffire Apr 5, 2024

Choose a reason for hiding this comment

eyebrowsoffire Apr 5, 2024

Choose a reason for hiding this comment

yjbanov left a comment

Choose a reason for hiding this comment