-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] deferred-loading "part" files not generated in Flutter 3.20.0+ #145653
Labels
a: build
Building flutter applications with the tool
assigned for triage
issue is assigned to a domain expert for further triage
c: regression
It was better in the past than it is now
found in release: 3.19
Found to occur in 3.19
found in release: 3.21
Found to occur in 3.21
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
platform-web
Web applications specifically
r: fixed
Issue is closed as already fixed in a newer version
team-web
Owned by Web platform team
tool
Affects the "flutter" command-line tool. See also t: labels.
Comments
amake
added a commit
to amake/isittofu
that referenced
this issue
Mar 24, 2024
danagbemava-nc
changed the title
Web deferred-loading "part" files not generated in Flutter 3.20.0+
[Web] deferred-loading "part" files not generated in Flutter 3.20.0+
Mar 25, 2024
danagbemava-nc
added
c: regression
It was better in the past than it is now
tool
Affects the "flutter" command-line tool. See also t: labels.
platform-web
Web applications specifically
a: build
Building flutter applications with the tool
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
team-web
Owned by Web platform team
found in release: 3.19
Found to occur in 3.19
found in release: 3.21
Found to occur in 3.21
and removed
in triage
Presently being triaged by the triage team
labels
Mar 25, 2024
Reproducible using the code sample and steps outlined above. flutter doctor -v
|
yjbanov
added
the
assigned for triage
issue is assigned to a domain expert for further triage
label
Apr 4, 2024
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this issue
Apr 5, 2024
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
5 tasks
danagbemava-nc
added
the
r: fixed
Issue is closed as already fixed in a newer version
label
Apr 8, 2024
auto-submit bot
pushed a commit
that referenced
this issue
Apr 8, 2024
…146361) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request) ### Issue Link: #145653 ### Changelog Description: Fixes and issue where dart2js deferred part files were not being properly emitted by a web build. ### Impact Description: Users who use deferred loading in dart2js will not have any of the deferred JS files copied to their build directory. ### Workaround: Users can manually copy the part files out of the `.dart_tool/flutter_build` directory into their `build/web` folder. ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: Follow the repro steps listed in #145653. Ensure that the `build/web` folder contains the `main.dart.js_1.part.js` and `main.dart.js_1.part.js.map` files.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this issue
Apr 22, 2024
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: build
Building flutter applications with the tool
assigned for triage
issue is assigned to a domain expert for further triage
c: regression
It was better in the past than it is now
found in release: 3.19
Found to occur in 3.19
found in release: 3.21
Found to occur in 3.21
has reproducible steps
The issue has been confirmed reproducible and is ready to work on
platform-web
Web applications specifically
r: fixed
Issue is closed as already fixed in a newer version
team-web
Owned by Web platform team
tool
Affects the "flutter" command-line tool. See also t: labels.
Steps to reproduce
With Flutter 3.19.4 generate a new project with
flutter create my_project
Next to main.dart, introduce a new file foo.dart:
In main.dart, import foo as a deferred library and make trivial use of it:
Run
flutter build web
and note that build/web/main.dart.js_1.part.js is generatedUpgrade to Flutter 3.20.0+
Run
flutter clean && flutter build web
and note that no *.part.js is generated. When deployed, the built application will fail due to missing the part files.Expected results
The build/web/*.part.js files should be built as with Flutter 3.19 and earlier.
Actual results
The build/web/*.part.js files are not built.
Code sample
Code sample
main.dart
foo.dart
Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Logs
Logs
Executed command
Flutter 3.19
https://pastebin.com/aLtvFY2c
Flutter 3.20
https://pastebin.com/U7s4MJd7
Flutter Doctor output
Doctor output
Flutter 3.19
Flutter 3.20
The text was updated successfully, but these errors were encountered: