Fix warning about angle_build_all being unread on Mac builds. #41176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Apr 13, 2023
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 41176, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dnfield
approved these changes
Apr 13, 2023
loic-sharma
approved these changes
Apr 13, 2023
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
…124886) flutter/engine@87fc464...9c31406 2023-04-14 [email protected] Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 [email protected] Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 [email protected] Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 [email protected] Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 [email protected] Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124886) flutter/engine@87fc464...9c31406 2023-04-14 [email protected] Run the Mac impeller-cmake-example orchestrator on arm64 (flutter/engine#41194) 2023-04-14 [email protected] Fix warning about angle_build_all being unread on Mac builds. (flutter/engine#41176) 2023-04-14 [email protected] Change v2 `mac_android_aot_engine` orchestrator builder to Linux (flutter/engine#41181) 2023-04-14 [email protected] Do not run mac unit tests on macmini7,1 (flutter/engine#41203) 2023-04-14 [email protected] Manual roll Skia from ad2e21650306 to 2bd12e31d578 (14 revisions) (flutter/engine#41206) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jwoelke
added a commit
to LibertyGlobal/flutter-tvos-engine
that referenced
this pull request
May 4, 2023
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
Jul 2, 2023
DenisovAV
pushed a commit
to DenisovAV/flutter-tvos-engine
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.