fix: mitigates console warning #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
|
Fresh installed Edge on macos. I have built fluidd and host it with worldwideweb 🤔 Very weird, I will test it on windows later. Bildschirmaufnahme.2022-07-28.um.16.47.52.mov |
|
Given what you said on the other discussion, maybe this is a Safari issue? |
The same on Windows 🤔 |
Signed-off-by: Pedro Lamas <[email protected]>
|
Cool, marking as ready for review then! 🙂 |
matmen
previously approved these changes
Aug 1, 2022
Signed-off-by: Pedro Lamas <[email protected]>
matmen
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates the following warning:
From my tests with Edge and Chrome on Windows 11, it seems to work fine with the value back in!
This is a follow up on this discussion: #774 (comment)
Signed-off-by: Pedro Lamas [email protected]