feat: match theme-color with primary-color #774
Conversation
Signed-off-by: Kerim Bilgic <[email protected]>
|
neat, thanks! |
| @@ -19,7 +19,7 @@ module.exports = defineConfig({ | |||
| } | |||
| }, | |||
| pwa: { | |||
| themeColor: '#2196F3', | |||
| themeColor: '', | |||
There was a problem hiding this comment.
@BastelKlug was there any specific reason for this line to change?
I ask this as I've noticed this warning on the console caused by it:
There was a problem hiding this comment.
Yes, when I removed the line, it took the default value from the plugin. So I left it blank. Maybe there is another way 🤔
There was a problem hiding this comment.
MS Edge in Win11 seems to work fine with the value in... What browser/phone did you notice that you needed to clear that? Might be the case here...
There was a problem hiding this comment.
Chrome on Windows 11. Maybe it was a bug with the Vue Cli Hot reloading?
There was a problem hiding this comment.
Chrome on MacOS, also does not work:
Bildschirmaufnahme.2022-07-28.um.16.14.51.mov
And also the bar in Safari that you see when you scroll up too high:
There was a problem hiding this comment.
Ah, I just tested with Chrome on Win11 and worked fine... guess this is a Mac thing only then?
Closes: #406
Hi, I think the changes are self-explaining.
Here is a demo video:
theme-color.mp4
Signed-off-by: Kerim Bilgic [email protected]