Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress output #7

Merged
merged 7 commits into from
Apr 20, 2021
Merged

Progress output #7

merged 7 commits into from
Apr 20, 2021

Conversation

weefuzzy
Copy link
Member

adds

  • a fixed width progress output (no fancy terminal progress bar, but hopefully parse-able by both people and machines),
  • Writing <X> during the output rendering (as this can take a while as well).

This is based on the work @jamesb93 did in his PR #2, mostly just tweaking the output formatting and merging updates back in.

This, hopefully, makes things feel a little more responsive. Feedback sought (incl. @jamesb93 – can you try with ReaCoMa and confirm (or not) that you can work with this).

I guess if it turns out people are doing a lot of shell scripty stuff and don't want the noise, we can add a --quiet switch.

@weefuzzy weefuzzy requested review from g-roma and tremblap September 30, 2020 16:26
@weefuzzy weefuzzy linked an issue Sep 30, 2020 that may be closed by this pull request
@weefuzzy weefuzzy mentioned this pull request Sep 30, 2020
@jamesb93
Copy link
Member

I will take a gander at this now!

@jamesb93
Copy link
Member

On really big files you won't see any progress output while its doing the internal copying. Maybe it could post 0% straight away? Minor pick though, otherwise it looks great!

@tremblap
Copy link
Member

it works. a strange behaviour, when one runs it with erroneous arguments, like fluid.hpss all by itself, one get:

./fluid-hpss
100%
Input buffer not set

getting the 100% before is not ideal, no?

@weefuzzy weefuzzy merged commit 4158540 into master Apr 20, 2021
@weefuzzy weefuzzy deleted the progress-output branch November 30, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

progress outputs
3 participants