Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress output #2

Merged
merged 4 commits into from
Sep 5, 2020
Merged

Conversation

jamesb93
Copy link
Member

This adds progress output to command line processes with std::cout.

@weefuzzy weefuzzy self-assigned this Sep 5, 2020
@weefuzzy weefuzzy self-requested a review September 5, 2020 08:30
@weefuzzy
Copy link
Member

weefuzzy commented Sep 5, 2020

Thanks for this @jamesb93!

Q: what do you need, ideally, for ReaCoMa in terms of output formatting? Thinking I might convert to a percentage for CLI users, as it's slightly more readable and will pave the way for a future progress bar thingy, but happy to add in some options so that you can have something easily parse-able from Lua if needed.

@jamesb93
Copy link
Member Author

jamesb93 commented Sep 5, 2020

Ideally? Simple as possible is good so that it can be parsed out into a number. Second best case is there is a word near it like progress: 50% in which case the bits around the number should be the same length at all times.

Lua could quite flexibly work around whatever comes out as a long as its consistent. Thanks for consideirng me!

@weefuzzy weefuzzy changed the base branch from master to feature/progress September 5, 2020 13:32
Copy link
Member

@weefuzzy weefuzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending some further experimentation by me about how to make it look nicer in terminal, and perhaps make the whole thing optional

@weefuzzy weefuzzy merged commit 15739cd into flucoma:feature/progress Sep 5, 2020
@weefuzzy weefuzzy mentioned this pull request Sep 30, 2020
@weefuzzy weefuzzy linked an issue Sep 30, 2020 that may be closed by this pull request
@weefuzzy weefuzzy removed a link to an issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants