Skip to content

Commit

Permalink
podman-remote: default PullPolicy must be missing instead of empty str
Browse files Browse the repository at this point in the history
If registry is remote default pull policy must be `missing` instead of
remote. Since `empty str == pullpolicy {always}` for more context on
this behaviour check containers#10739

[NO TESTS NEEDED]

Signed-off-by: Aditya Rajan <[email protected]>
  • Loading branch information
flouthoc committed Nov 8, 2021
1 parent abbd6c1 commit 947aefd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion cmd/podman/common/create_opts.go
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,11 @@ func policy() string {
if !registry.IsRemote() {
return containerConfig.Engine.PullPolicy
}
return ""
// If registry is remote default pull policy
// must be "missing" instead of empty string.
// since empty string == PullPolicy {always}
// more context: https://github.com/containers/podman/pull/10739
return config.DefaultPullPolicy
}

func shmSize() string {
Expand Down

0 comments on commit 947aefd

Please sign in to comment.