create: support images with invalid platform #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
4d9bfb8 to
b2f0f8e
Compare
|
Also fixes: #10648 |
vrothberg
added
the
needs-backport
|
Needs a backport to the v3.2 branch. |
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 21, 2021
As it turned out in Podman CI (containers/podman/pull/10739), the policy is overridden via --arch/os/platform/variant even when the policy is set to never. While I think this is a bug, it is a separate one and must tackled separately. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
efc5174 to
940423b
Compare
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 21, 2021
As it turned out in Podman CI (containers/podman/pull/10739), the policy is overridden via --arch/os/platform/variant even when the policy is set to never. While I think this is a bug, it is a separate one and must tackled separately. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
90bb381 to
854e61f
Compare
|
Still fighting the good fight with the CI here @vrothberg |
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
af15501 to
71fb632
Compare
This one really unfolds like origami :^) |
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
cac0320 to
3e9645e
Compare
|
In case somebody is restarting the jobs, please don't. They look like infra problems but I want to see the errors. |
vrothberg
force-pushed
the
fix-10682
branch
2 times, most recently
from
06ec5d9 to
5bcb11b
Compare
|
Let's see if it's better now. Finally managed to get the logs of a failing int remote test. Had to massage the remote pulling code a bit and wire the pull policy through. |
Much to my regret, there is a number of images in the wild with invalid platforms breaking the platform checks in libimage that want to make sure that a local image is matching the expected platform. Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora image. We really shouldn't use the local one in this case and pull down the arm64 one. The strict platform checks in libimage in combination with invalid platforms in images surfaced in Podman being able to pull an image but failing to look it up in subsequent presence checks. A `podman run` would hence pull such an image but fail to create the container. Support images with invalid platforms by vendoring the latest HEAD from containers/common. Also remove the partially implemented pull-policy logic from Podman and let libimage handle that entirely. However, whenever --arch, --os or --platform are specified, the pull policy will be forced to "newer". This way, we pessimistically assume that the local image has an invalid platform and we reach out to the registry. If there's a newer image (i.e., one with a different digest), we'll pull it down. Please note that most of the logic has either already been implemented in libimage or been moved down which allows for removing some clutter from Podman. [NO TESTS NEEDED] since c/common has new tests. Podman can rely on the existing tests. Fixes: containers#10648 Fixes: containers#10682 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 23, 2021
As it turned out in Podman CI (containers/podman/pull/10739), the policy is overridden via --arch/os/platform/variant even when the policy is set to never. While I think this is a bug, it is a separate one and must tackled separately. Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
added a commit
to vrothberg/common
that referenced
this pull request
Jun 23, 2021
As it turned out in Podman CI (containers/podman/pull/10739), the policy is overridden via --arch/os/platform/variant even when the policy is set to never. While I think this is a bug, it is a separate one and must tackled separately. Signed-off-by: Valentin Rothberg <[email protected]>
Merged
|
@containers/podman-maintainers merge me |
|
LGTM |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
flouthoc
added a commit
to flouthoc/podman
that referenced
this pull request
Nov 8, 2021
If registry is remote default pull policy must be `missing` instead of
remote. Since `empty str == pullpolicy {always}` for more context on
this behaviour check containers#10739
[NO TESTS NEEDED]
Signed-off-by: Aditya Rajan <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much to my regret, there is a number of images in the wild with invalid
platforms breaking the platform checks in libimage that want to make
sure that a local image is matching the expected platform.
Imagine a
podman run --arch=arm64 fedorawith a local amd64 fedoraimage. We really shouldn't use the local one in this case and pull down
the arm64 one.
The strict platform checks in libimage in combination with invalid
platforms in images surfaced in Podman being able to pull an image but
failing to look it up in subsequent presence checks. A
podman runwould hence pull such an image but fail to create the container.
Support images with invalid platforms by vendoring the latest HEAD from
containers/common. Also remove the partially implemented pull-policy
logic from Podman and let libimage handle that entirely. However,
whenever --arch, --os or --platform are specified, the pull policy will
be forced to "newer". This way, we pessimistically assume that the
local image has an invalid platform and we reach out to the registry.
If there's a newer image (i.e., one with a different digest), we'll pull
it down.
Please note that most of the logic has either already been implemented
in libimage or been moved down which allows for removing some clutter
from Podman.
Fixes: #10682
Signed-off-by: Valentin Rothberg [email protected]