make 'fips update' check for existing git repository #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhoh, github's merge UI is behaving strangely at the moment... I pressed the merge button, but nothing happened, pressed again and the merge showed as failed. Now the Merge button is grayed out. Looking at the main page it looks like the PR was merged, but it's still showing up as open here. Only option I have now is to close the PR, which I'll do now :) (...and I'm getting a lot of "you can't comment at this time") |
|
...for future reference: the PR has been merged d0194ee |
code-disaster
pushed a commit
to code-disaster/fips
that referenced
this pull request
Jun 20, 2019
make 'fips update' check for existing git repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns 'fips update' with the change to 'fips diag imports' in #196 .
Right now, if a dependency isn't a "real" Git repository, 'fips update' just tries to run submodule updates on the parent repository instead, if there are any.
I also removed that one comment line which didn't fit, probably a copy&paste leftover from
_rec_fetch_imports().