Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some QoL changes #196

Merged
merged 3 commits into from
Jul 13, 2018
Merged

Some QoL changes #196

merged 3 commits into from
Jul 13, 2018

Conversation

code-disaster
Copy link
Contributor

A couple of small edits I did in the past days/weeks since I use fips more regularly. Feel free to cherry-pick as you like.

  • typo in fips markdeep error message
  • on fips clean all, do not echo all of the 106 default plus N user-defined configs
  • I also added my change discussed in Interesting fix/hack/workaround for 'local' dependencies... #186 which skips the call to git.check_out_of_sync() if the dependency's root folder doesn't have a .git/ subfolder.

…repository

see floooh#186 for an outline; this commit just prevents 'fips diag' to falsely report status of a parent repository, if there is one.
@code-disaster
Copy link
Contributor Author

regarding the third edit, another way I found is to change the git command issued to git status -s . - maybe even less intrusive.

@floooh floooh merged commit adcdadd into floooh:master Jul 13, 2018
@floooh
Copy link
Owner

floooh commented Jul 13, 2018

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants