Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS not rendering data in UI #396

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fix JS not rendering data in UI #396

merged 1 commit into from
Mar 9, 2021

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Mar 9, 2021 •
edited
Loading

Fixes: #394
Fixes: #391

It seems the dependency update for Buefy in 76c4f92 broke the UI

TODO

  1. Figure out why it broke it
  2. Add tests to ensure we dont reproduce this issue in the future (Why didn't the ITs catch it?)
  3. Determine if there is a upgrade path for Buefy that doesnt break the UI

This was referenced Mar 9, 2021
Closed
Closed
Merged
@markphelps markphelps merged commit fedcb45 into master Mar 9, 2021
@markphelps markphelps deleted the fix-js-ui branch March 9, 2021 21:26
@edumucelli
Copy link
Contributor

Great to hear that! Congrats on finding the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: javascript error - no flags or segments UI fails to render segments or flags
2 participants
@markphelps @edumucelli