Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces 0.0.0.0 by 127.0.0.1 on the codebase #388

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

edumucelli
Copy link
Contributor

@edumucelli edumucelli commented Feb 18, 2021

As discussed in #385 this is the step 2: align the codebase to spin up the service and expect it on 127.0.0.1 instead of 0.0.0.0.
To be applied whenever @markphelps release a new version, to avoid any back-compatibility issues you may have in mind.

A new demo.gif is required.

@markphelps
Copy link
Collaborator

@all-contributors please add @edumucelli for code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @edumucelli! 🎉

@markphelps
Copy link
Collaborator

@edumucelli thanks for the PR!

I'm getting some weird issues when trying to run locally though via make dev.

In the screenshots below you can see that the API is returning flag results, however the UI can't seem to render them. I'm wondering if it has to do with some cross-origin issues resulting from these changes?

Screen Shot 2021-02-19 at 9 45 51 AM

Screen Shot 2021-02-19 at 9 45 42 AM

Screen Shot 2021-02-19 at 9 46 40 AM

@edumucelli
Copy link
Contributor Author

Hmm, indeed, I can reproduce it. Somehow when setting "127.0.0.1:8080" on api.js is not working as expected. I have basically on knowledge on JS frameworks. I will see if I can debug it somehow. Thanks for the feedback.

@markphelps
Copy link
Collaborator

Hmm, indeed, I can reproduce it. Somehow when setting "127.0.0.1:8080" on api.js is not working as expected. I have basically on knowledge on JS frameworks. I will see if I can debug it somehow. Thanks for the feedback.

No prob. I will look into this as well. I'm starting to think that this issue may be why I chose 0.0.0.0 in the first place.. but there has to be a solution.. so I will keep 👀

@markphelps
Copy link
Collaborator

@edumucelli FYI I think #396 will fix the issue we were seeing, so after that is merged this PR should be good to go

@edumucelli
Copy link
Contributor Author

@edumucelli FYI I think #396 will fix the issue we were seeing, so after that is merged this PR should be good to go

That is neat! Looking forward to see it merged!

@markphelps markphelps merged commit b8d0ac8 into flipt-io:master Mar 10, 2021
@markphelps
Copy link
Collaborator

Thanks @edumucelli !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants