-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces 0.0.0.0 by 127.0.0.1 on the codebase #388
Replaces 0.0.0.0 by 127.0.0.1 on the codebase #388
Conversation
@all-contributors please add @edumucelli for code |
I've put up a pull request to add @edumucelli! 🎉 |
@edumucelli thanks for the PR! I'm getting some weird issues when trying to run locally though via In the screenshots below you can see that the API is returning flag results, however the UI can't seem to render them. I'm wondering if it has to do with some cross-origin issues resulting from these changes? |
Hmm, indeed, I can reproduce it. Somehow when setting |
No prob. I will look into this as well. I'm starting to think that this issue may be why I chose |
@edumucelli FYI I think #396 will fix the issue we were seeing, so after that is merged this PR should be good to go |
That is neat! Looking forward to see it merged! |
Thanks @edumucelli ! |
As discussed in #385 this is the step 2: align the codebase to spin up the service and expect it on 127.0.0.1 instead of 0.0.0.0.
To be applied whenever @markphelps release a new version, to avoid any back-compatibility issues you may have in mind.
A new
demo.gif
is required.