-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Grpc inproc #3856
chore: use Grpc inproc #3856
Conversation
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3856 +/- ##
==========================================
- Coverage 64.85% 63.61% -1.24%
==========================================
Files 171 171
Lines 17400 17380 -20
==========================================
- Hits 11284 11057 -227
- Misses 5418 5657 +239
+ Partials 698 666 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Well something doesn't work quite right it seems |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Im guessing something to do with the middleware as its not failing wholesale to perform operations. The ITs used to have the protocol used in the test reported, but I think that is missing from the test output now. |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Somehow |
Signed-off-by: Roman Dmytrenko <[email protected]>
Thank you @erka ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a performance perspective, the results are very promising. wrk benchmarking on my laptop indicates a doubling of speed for response time.
Awesome! My next step was gonna be to benchmark and also do some more testing to make sure everything works correctly |
@erka would you mind sharing your benchmark setup and/or results here in a comment and I'll do the same? |
…grpc-inproc * 'grpc-inproc' of https://github.com/flipt-io/flipt: return value instead of nil
Signed-off-by: Mark Phelps <[email protected]>
I just use go-wrk -M POST -H "Content-Type: application/json" -H "Accept: application/json" -body '{"flagKey":"color-scheme","entityId":"a","context":{"subscription":"active"},"namespaceKey":"default"}' -d 30 http://localhost:8080/evaluate/v1/variant |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Before (main branch)
After (this branch)
|
Signed-off-by: Mark Phelps <[email protected]>
…grpc-inproc * 'grpc-inproc' of https://github.com/flipt-io/flipt: fix(ui): ui.topbar.color config setting has been broken since v1.53.0 (#3857)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👌
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
This reverts commit 09c5766.
Re: https://www.bwplotka.dev/2025/go-grpc-inprocess-iter/
Switches to an inprocess channel for routing GRPC gateway requests to the GRPC server
This should be much more performant since we don't need to go over the loopback network as described in above blog post ☝🏻