fix(ui): ui.topbar.color config setting has been broken since v1.53.0 #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression when `/meta/config` was replaced with `/meta/info` for UI. Signed-off-by: Roman Dmytrenko <[email protected]>
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3857 +/- ##
=======================================
Coverage 64.85% 64.85%
=======================================
Files 171 171
Lines 17400 17400
=======================================
Hits 11284 11284
Misses 5418 5418
Partials 698 698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GeorgeMac
approved these changes
Jan 31, 2025
markphelps
added a commit
that referenced
this pull request
Jan 31, 2025
…grpc-inproc * 'grpc-inproc' of https://github.com/flipt-io/flipt: fix(ui): ui.topbar.color config setting has been broken since v1.53.0 (#3857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression when
/meta/configwas replaced with/meta/infofor UI.Refs: #3684