Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up e2e tests #253

Merged
merged 9 commits into from
Mar 27, 2020
Merged

Set up e2e tests #253

merged 9 commits into from
Mar 27, 2020

Conversation

jperl
Copy link
Contributor

@jperl jperl commented Mar 22, 2020

Resolves #216

To Do

  • set up CI
  • add test attributes & update tests

@jperl
Copy link
Contributor Author

jperl commented Mar 22, 2020

@markphelps This is a WIP PR, I will follow up shortly with the remaining TODOs. I started with two basic e2e tests, creating a flag and create a segment.

I am also recording a video as I set it up, in case you are interested in the process. This is the first video https://www.youtube.com/watch?v=Wa6MFqrf0Nc

@jperl
Copy link
Contributor Author

jperl commented Mar 23, 2020

Pt. 2 of the setup video: https://www.youtube.com/watch?v=5r8k14MT-O0

It now runs the tests against the docker image in CI.

You can download or watch a video of the tests in the artifacts.

I will work on updating the ui to have test attributes tomorrow.

@markphelps
Copy link
Collaborator

This is amazing. Thank you @jperl and I love the videos. What screen capture program do you use?

@jperl
Copy link
Contributor Author

jperl commented Mar 24, 2020

We built playwright-video which uses Chrome DevTools screencast to collect the images, and ffmpeg to construct the video.

@jperl
Copy link
Contributor Author

jperl commented Mar 25, 2020

@markphelps I updated the front end to have test attributes where needed to improve the selectors. QA Wolf will automatically find these attributes and use them as selectors.

The tests pass locally, but the GitHub action needs to run the latest code instead of the latest docker for them to pass.

@jperl jperl marked this pull request as ready for review March 25, 2020 20:06
@jperl
Copy link
Contributor Author

jperl commented Mar 25, 2020

What screen capture program do you use?

I probably misunderstood this :). The youtube videos I livestream with OBS.

@markphelps
Copy link
Collaborator

@jperl awesome thank you so much for your hard work! will check it out this evening and merge

When you say:

The tests pass locally, but the GitHub action needs to run the latest code instead of the latest docker for them to pass.

Do you mean that the current Docker image doesnt the required dependencies that you install here?

@markphelps
Copy link
Collaborator

@all-contributors please add @jperl for test and code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @jperl! 🎉

@jperl
Copy link
Contributor Author

jperl commented Mar 26, 2020

Do you mean that the current Docker image doesnt the required dependencies that you install here?

No, rather the GitHub action currently spins up the docker image instead of running the server and front end from the latest code, and the tests run against that. That should be easy to change.

@markphelps
Copy link
Collaborator

Oh gotcha. Yah i'll fix that this weekend. Thanks again for adding these tests!!!

@markphelps markphelps merged commit cfc802c into flipt-io:master Mar 27, 2020
@jperl
Copy link
Contributor Author

jperl commented Mar 27, 2020

My pleasure. Happy to help adding more just let me know.

@jperl jperl deleted the e2e branch March 27, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e UI tests
2 participants