-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up e2e tests #253
Set up e2e tests #253
Conversation
@markphelps This is a WIP PR, I will follow up shortly with the remaining TODOs. I started with two basic e2e tests, creating a flag and create a segment. I am also recording a video as I set it up, in case you are interested in the process. This is the first video https://www.youtube.com/watch?v=Wa6MFqrf0Nc |
Pt. 2 of the setup video: https://www.youtube.com/watch?v=5r8k14MT-O0 It now runs the tests against the docker image in CI. You can download or watch a video of the tests in the artifacts. I will work on updating the ui to have test attributes tomorrow. |
This is amazing. Thank you @jperl and I love the videos. What screen capture program do you use? |
We built playwright-video which uses Chrome DevTools screencast to collect the images, and ffmpeg to construct the video. |
- remove slowMo from test
@markphelps I updated the front end to have test attributes where needed to improve the selectors. QA Wolf will automatically find these attributes and use them as selectors. The tests pass locally, but the GitHub action needs to run the latest code instead of the latest docker for them to pass. |
I probably misunderstood this :). The youtube videos I livestream with OBS. |
@jperl awesome thank you so much for your hard work! will check it out this evening and merge When you say:
Do you mean that the current Docker image doesnt the required dependencies that you install here? |
@all-contributors please add @jperl for test and code |
I've put up a pull request to add @jperl! 🎉 |
No, rather the GitHub action currently spins up the docker image instead of running the server and front end from the latest code, and the tests run against that. That should be easy to change. |
Oh gotcha. Yah i'll fix that this weekend. Thanks again for adding these tests!!! |
My pleasure. Happy to help adding more just let me know. |
Resolves #216
To Do