Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e UI tests #216

Closed
markphelps opened this issue Feb 1, 2020 · 3 comments · Fixed by #253
Closed

Add e2e UI tests #216

markphelps opened this issue Feb 1, 2020 · 3 comments · Fixed by #253
Assignees
Labels

Comments

@markphelps
Copy link
Collaborator

markphelps commented Feb 1, 2020

Is your feature request related to a problem? Please describe.
Add some end to end UI tests to verify that changes do not break the Flipt UI and that users see the expected results.

Describe the solution you'd like
Perhaps something like testcafe? I dont know much about the 'modern' e2e Javascript testing frameworks.. but I know things I DO NOT WANT:

No ❌ :

  • Selenium or browser based tests as these are slow and error prone
  • BDD testing language, just want simple easy to write expectation based tests

Additional context
Something that could capture screenshots when tests fail would be nice too for local development

@jperl
Copy link
Contributor

jperl commented Mar 12, 2020

👋 Hello I maintain an open source library that generates Playwright code. I would be happy to submit PRs setting up e2e tests, if you are cool with them using Playwright?

@markphelps
Copy link
Collaborator Author

@jperl Yes that would be awesome! This is the first I've heard of Playwright, but it looks great, as does QAWolf (love your landing page btw).

@jperl
Copy link
Contributor

jperl commented Mar 13, 2020

Thank you :). Awesome, I will start working on a PR next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants