Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): move Rules to use Redux for storage #2461

Merged
merged 2 commits into from
Nov 28, 2023
Merged

refactor(ui): move Rules to use Redux for storage #2461

merged 2 commits into from
Nov 28, 2023

Conversation

erka
Copy link
Collaborator

@erka erka commented Nov 27, 2023

Refs: #2435

@erka erka requested a review from a team as a code owner November 27, 2023 09:13
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5aef5a1) 70.72% compared to head (8010aaa) 70.76%.
Report is 1 commits behind head on main.

❗ Current head 8010aaa differs from pull request most recent head 5afe41d. Consider uploading reports for the commit 5afe41d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2461      +/-   ##
==========================================
+ Coverage   70.72%   70.76%   +0.04%     
==========================================
  Files          81       81              
  Lines        8139     8110      -29     
==========================================
- Hits         5756     5739      -17     
+ Misses       2036     2025      -11     
+ Partials      347      346       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka erka mentioned this pull request Nov 28, 2023
Closed
markphelps
markphelps approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! thank you @erka , amazing as usual

@markphelps markphelps merged commit 3809557 into flipt-io:main Nov 28, 2023
27 checks passed
@erka erka deleted the use-redux-for-rules branch November 28, 2023 15:11
@markphelps markphelps mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erka @markphelps