Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Rollouts to use Redux storage #2434

Closed
markphelps opened this issue Nov 22, 2023 · 2 comments · Fixed by #2465
Closed

Move Rollouts to use Redux storage #2434

markphelps opened this issue Nov 22, 2023 · 2 comments · Fixed by #2465
Assignees
@erka
Labels
good first issue help wanted Halp ui

Comments

@markphelps
Copy link
Collaborator

Re: FLI-650

We'd like to use Redux as the storage abstraction in the UI.

As per #2301, we need to update Rollouts resources in the UI to work through Redux.
@erka
Copy link
Collaborator

erka commented Nov 27, 2023

I'll work on it

erka added a commit to erka/flipt that referenced this issue Nov 27, 2023
@erka
refactor(ui): move Rollouts to use Redux storage
c92a6ac 
Refs: flipt-io#2434
erka added a commit to erka/flipt that referenced this issue Nov 27, 2023
@erka
refactor(ui): move Rollouts to use Redux storage
2a6279f 
Refs: flipt-io#2434
@erka
Copy link
Collaborator

erka commented Nov 28, 2023

I think I've completed this but I don't want to open the PR as there will be a merge conflict with #2461. I will wait until that PR is merged.

erka added a commit to erka/flipt that referenced this issue Nov 28, 2023
@erka
refactor(ui): move Rollouts to use Redux storage
7996153 
Refs: flipt-io#2434
@erka erka mentioned this issue Nov 28, 2023
Merged
erka added a commit to erka/flipt that referenced this issue Nov 28, 2023
@erka
refactor(ui): move Rollouts to use Redux storage
a7d2153 
Refs: flipt-io#2434
@kodiakhq kodiakhq bot closed this as completed in #2465 Nov 29, 2023
kodiakhq bot added a commit that referenced this issue Nov 29, 2023
@erka @markphelps @kodiakhq
refactor(ui): move Rollouts to use Redux storage (#2465)
035de76 
* refactor(ui): move Rollouts to use Redux storage

Refs: #2434

* fix the issue reported by eslint

* it should be finally fixed

---------

Co-authored-by: Mark Phelps <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erka erka

Labels
good first issue help wanted Halp ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(ui): move Rollouts to use Redux storage erka/flipt
2 participants
@erka @markphelps