feat(ui/tokens): delete multiple tokens

[erka]

Refs: #2275, FLI-215

[erka]

@markphelps please take a look and provide feedback.

The delete button is too big as the replacement of 'Name'. Any workaround for it?
The delete token modal probably should better formatting for multiple tokens. Any suggestions?
Anything else?

[markphelps]

@erka this looks great! I responded to most the questions in the PR on your PR erka#1

I think its ok that the Delete button hides the name field on the table

Really appreciate this!! Works great!

[erka]

There is some side effect which happens right now. After deletions the tokens if you create the new one it will be selected for deletion. I believe the rowSelection state isn't cleanup up after the api calls. If the rowSelection will be move to the Tokens.tsx but then you need RowSelectionState there which looks bad.

By the way there is one strange state with filter too in main branch. If you use filter to find one token and delete it you will see a blank table and no filter input... It looks like as a bug.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b054623) 70.76% compared to head (f7b40cf) 70.76%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2424   +/-   ##
=======================================
  Coverage   70.76%   70.76%           
=======================================
  Files          81       81           
  Lines        8110     8110           
=======================================
  Hits         5739     5739           
  Misses       2025     2025           
  Partials      346      346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[markphelps]

@erka what do you think about erka#2 , which passes down the existing tokensVersion prop to then reset selected rows if the underlying tokens change (such as delete)?

I think it might be nicer than using events?

By the way there is one strange state with filter too in main branch. If you use filter to find one token and delete it you will see a blank table and no filter input... It looks like as a bug.

Yes ☝🏻 def sounds like a bug. We should file and fix that. I'm happy to file it in the morning (US) or if you are able to first, either way.

Thank you again for this contribution!!

[markphelps]

thank you for the contribution @erka !! Looks great and very much appreciated!

[markphelps]

@all-contributors please add @erka for code

[allcontributors]

@markphelps

I've put up a pull request to add @erka! 🎉

[markphelps]

Will create a release later today with this