Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLI-640] Delete Multiple Tokens #2275

Closed
markphelps opened this issue Oct 25, 2023 · 2 comments
Closed

[FLI-640] Delete Multiple Tokens #2275

markphelps opened this issue Oct 25, 2023 · 2 comments
Labels
good first issue ui
Milestone
v.30

Comments

@markphelps
Copy link
Collaborator

markphelps commented Oct 25, 2023 •
edited
Loading

Ability to delete multiple tokens in batch via UI

CleanShot 2023-10-25 at 11 53 46

From SyncLinear.com | FLI-215
@markphelps markphelps changed the title [FLI-215] Delete Multiple Tokens [FLI-640] [FLI-215] Delete Multiple Tokens Oct 25, 2023
@markphelps markphelps changed the title [FLI-640] [FLI-215] Delete Multiple Tokens [FLI-215] Delete Multiple Tokens Oct 25, 2023
@markphelps markphelps changed the title [FLI-215] Delete Multiple Tokens Delete Multiple Tokens Oct 25, 2023
@markphelps markphelps changed the title Delete Multiple Tokens [FLI-640] Delete Multiple Tokens Oct 25, 2023
@erka erka mentioned this issue Nov 19, 2023
Closed
@markphelps
Copy link
Collaborator Author

@erka was thinking something like this:

shapes at 23-11-20 16 25 47

I have some code from TailwindUI that I can provide to handle the state management if that helps

erka added a commit to erka/flipt that referenced this issue Nov 21, 2023
@erka
feat(ui/tokens): delete multiple tokens
c2f753c 
Refs: flipt-io#2275, FLI-215
erka added a commit to erka/flipt that referenced this issue Nov 21, 2023
@erka
feat(ui/tokens): delete multiple tokens
682c036 
Refs: flipt-io#2275, FLI-215
@erka erka mentioned this issue Nov 21, 2023
Merged
erka added a commit to erka/flipt that referenced this issue Nov 21, 2023
@erka
feat(ui/tokens): delete multiple tokens
bd271c0 
Refs: flipt-io#2275, FLI-215
markphelps added a commit that referenced this issue Nov 22, 2023
@erka @markphelps
feat(ui/tokens): delete multiple tokens (#2424)
8a72265 
* feat(ui/tokens): delete multiple tokens

Refs: #2275, FLI-215

* - added delete button per spec
- implemented the logic for multiple tokens deletion
- some ui changes and cleanup

* feat: updates for delete multiple tokens PR

* cleanup selected rows after token deletions

* chore: use existing tokensVersion (#2)

---------

Co-authored-by: Mark Phelps <[email protected]>
@markphelps
Copy link
Collaborator Author

Fixed by #2424 🎉

@markphelps markphelps added this to the v.30 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue ui
Projects
None yet
Milestone
v.30
Development

No branches or pull requests
1 participant
@markphelps